-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add showing product update message #249
Conversation
ea4b88f
to
d9ef657
Compare
Hmm does the message just stay there? How do we remove the message once we are done announcing? |
Are you using Rails' flash message system? I think that feature is designed for exactly such purposes? |
Currently the message just stay there. I can add the function for maintainer to turn it on/ off
Yes I am using Rails' flash message |
Yeah adding a functionality to turn it on and off will be great! Please document the instructions you have provided in maybe an admin user guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add ability to turn the banner on/off and document steps in admin usage guide.
Done and updated PR description accordingly. New demo: https://youtu.be/DtyGSvB5m-U. |
Description
Allows maintainer to make product update announcements
Related Issue
#247
Motivation and Context
Prof @knmnyn's request
How Has This Been Tested?
Local testing
Screenshots (if appropriate):
Demo: https://youtu.be/DtyGSvB5m-U
The admin can set new messages or toggle the visibility of the message on/off using rake tasks
Types of changes
Checklist:
Closes 247.