Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add showing product update message #249

Merged
merged 6 commits into from
Jan 13, 2024

Conversation

sibinhho99
Copy link
Collaborator

@sibinhho99 sibinhho99 commented Dec 16, 2022

Description

Allows maintainer to make product update announcements

Related Issue

#247

Motivation and Context

Prof @knmnyn's request

How Has This Been Tested?

Local testing

Screenshots (if appropriate):

Demo: https://youtu.be/DtyGSvB5m-U

Screenshot 2022-12-16 at 2 48 48 PM

The admin can set new messages or toggle the visibility of the message on/off using rake tasks

Screenshot 2022-12-16 at 2 48 18 PM
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Closes 247.

@huyuxin0429
Copy link
Collaborator

Hmm does the message just stay there? How do we remove the message once we are done announcing?

@knmnyn
Copy link
Member

knmnyn commented Sep 13, 2023

Are you using Rails' flash message system? I think that feature is designed for exactly such purposes?

@sibinhho99
Copy link
Collaborator Author

Hmm does the message just stay there? How do we remove the message once we are done announcing?

Currently the message just stay there. I can add the function for maintainer to turn it on/ off

Are you using Rails' flash message system? I think that feature is designed for exactly such purposes?

Yes I am using Rails' flash message

@huyuxin0429
Copy link
Collaborator

Hmm does the message just stay there? How do we remove the message once we are done announcing?

Currently the message just stay there. I can add the function for maintainer to turn it on/ off

Are you using Rails' flash message system? I think that feature is designed for exactly such purposes?

Yes I am using Rails' flash message

Yeah adding a functionality to turn it on and off will be great! Please document the instructions you have provided in maybe an admin user guide.

Copy link
Collaborator

@huyuxin0429 huyuxin0429 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add ability to turn the banner on/off and document steps in admin usage guide.

@sibinhho99
Copy link
Collaborator Author

Please add ability to turn the banner on/off and document steps in admin usage guide.

Done and updated PR description accordingly. New demo: https://youtu.be/DtyGSvB5m-U.

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 4.218% (+0.03%) from 4.189%
when pulling 3806ce1 on sibinhho99:set_product_update
into 0fb4da9 on WING-NUS:master.

@huyuxin0429 huyuxin0429 merged commit 097fa5e into WING-NUS:master Jan 13, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add product update announcement
4 participants