Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API key handling and sample GET and POST #325

Closed
wants to merge 1 commit into from
Closed

Add API key handling and sample GET and POST #325

wants to merge 1 commit into from

Conversation

sibinhho99
Copy link
Collaborator

@sibinhho99 sibinhho99 commented Sep 16, 2023 •
edited
Loading

Description

Adds ability to handle API key and sample POST and GET

Related Issue

#324

Motivation and Context

Part of #324

How Has This Been Tested?

Local testing using curl as API client.

Bash script with curl commands for testing: https://drive.google.com/file/d/1H3Wch0lVF8GT3s-cticom-cGGfOa-wMw/view?usp=sharing

Screenshots (if appropriate):

Video demo: https://youtu.be/sSrIgyBcdhE

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sibinhho99 sibinhho99 self-assigned this Sep 16, 2023
@sibinhho99 sibinhho99 linked an issue Sep 16, 2023 that may be closed by this pull request
✨ Coursemology Integration Phase 1 Stage 2 #324
Closed
7 tasks
@sibinhho99
Copy link
Collaborator Author

I sent @florentianayuwono @mengyewgau a a manual patch file for this PR's commit 2b112a4 so that they can apply on their local branch and continue off it while this PR is under review

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 0.216% (-0.002%) from 0.218% when pulling c53ef31 on sibinhho99:api into 5ffee50 on WING-NUS:master.

@huyuxin0429
Copy link
Collaborator

Good progress! Let's merge this in once the full functionality has been developed with the relevant tests.

@huyuxin0429 huyuxin0429 added the Type: Feature A suggested idea for this project label Sep 19, 2023
huyuxin0429
huyuxin0429 requested changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@huyuxin0429 huyuxin0429 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, lets reopen this PR again when the full functionality has been developed along with the relevant test suites.

test/fixtures/api_keys.yml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed unused test files

test/models/api_key_test.rb
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed unused test files

@sibinhho99
Copy link
Collaborator Author

This PR has been incorporated into later PRs for the implementations of the routes

@sibinhho99 sibinhho99 closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huyuxin0429 huyuxin0429 huyuxin0429 requested changes

Assignees

@sibinhho99 sibinhho99

Labels
enhancement Type: Feature A suggested idea for this project
Projects
SSID Project
Status: Done
Milestone
Integration with Coursemology
Development

Successfully merging this pull request may close these issues.

✨ Coursemology Integration Phase 1 Stage 2
3 participants
@sibinhho99 @coveralls @huyuxin0429