Fix extra render when uploading invalid zip file #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
sibinhho99
merged commit d6a720f
into
WING-NUS:feature/ssid_coursemology_integration
2 of 3 checks passed
sibinhho99
added a commit
that referenced
this pull request
Oct 1, 2023
This reverts commit d6a720f.
sibinhho99
added a commit
that referenced
this pull request
Oct 1, 2023
|
Superseded by #345 |
huyuxin0429
pushed a commit
that referenced
this pull request
Oct 22, 2023
* Fix extra render when uploading invalid zip file
huyuxin0429
pushed a commit
that referenced
this pull request
Oct 22, 2023
huyuxin0429
pushed a commit
that referenced
this pull request
Jan 15, 2024
* Adds POST route for creating new assignments via API (#338) * Add API key and sample GET and POST * Implement POST API route for creating assignments * Add API key authentication handler * Run rubocop on assignments_controller * Reduce linter-flagged issues * Add API Phase 1 documentation (#336) * Add API Phase 1 documentation * Api/sub sim (#331) * Added API for GET all submission similarities of an assignment * Fix extra render when uploading invalid zip file (#342) * Fix extra render when uploading invalid zip file * Revert "Fix extra render when uploading invalid zip file (#342)" (#344) This reverts commit d6a720f. * Fix extra render when uploading invalid zip file * Add API route for GET Pair of flagged submission details (#341) * Add tests and bug fixes for api/v1/submission_similarities index and show * Add RSpec tests for POST /api/v1/courses/{course_id}/assignment/ * Update similarity percentage format it doc * Remove unused files and routes * Update/ Clarify API doc * added pagination * added to use the will_paginate gem * Added such that limit has higher precedence over pagination --------- Co-authored-by: sibinhho99 <sibinhho99@gmail.com> Co-authored-by: florentianayuwono <76247368+florentianayuwono@users.noreply.github.com>
huyuxin0429
added a commit
that referenced
this pull request
Jan 15, 2024
* Adds POST route for creating new assignments via API (#338) * Add API key and sample GET and POST * Implement POST API route for creating assignments * Add API key authentication handler * Run rubocop on assignments_controller * Reduce linter-flagged issues * Add API Phase 1 documentation (#336) * Add API Phase 1 documentation * Api/sub sim (#331) * Added API for GET all submission similarities of an assignment * Fix extra render when uploading invalid zip file (#342) * Fix extra render when uploading invalid zip file * Revert "Fix extra render when uploading invalid zip file (#342)" (#344) This reverts commit d6a720f. * Fix extra render when uploading invalid zip file * Add API route for GET Pair of flagged submission details (#341) * Add tests and bug fixes for api/v1/submission_similarities index and show * Add RSpec tests for POST /api/v1/courses/{course_id}/assignment/ * Update similarity percentage format it doc * Remove unused files and routes * Update/ Clarify API doc * added pagination * added to use the will_paginate gem * Added such that limit has higher precedence over pagination --------- Co-authored-by: Michael Gau <61722401+mengyewgau@users.noreply.github.com> Co-authored-by: sibinhho99 <sibinhho99@gmail.com> Co-authored-by: florentianayuwono <76247368+florentianayuwono@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
#343
Motivation and Context
Small bug which causes internal error when uploading invalid zip file instead of returning error message to the client
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: