Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature sort max and avg similarity first #374

Conversation

huyuxin0429
Copy link
Collaborator

@huyuxin0429 huyuxin0429 commented Nov 12, 2023

Description

This PR addresses urgent user need to change default sort behaviour to rank highest max similarity and avg similarity first.

Related Issue

This combines and closes #319

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@huyuxin0429 huyuxin0429 added the Type: Feature A suggested idea for this project label Nov 12, 2023
@huyuxin0429 huyuxin0429 self-assigned this Nov 12, 2023
@coveralls
Copy link
Collaborator

coveralls commented Nov 12, 2023

Coverage Status

coverage: 4.107% (-0.02%) from 4.124%
when pulling f39a3e0 on huyuxin0429:feature_sort_max_and_avg_similarity_first
into 0e0658c on WING-NUS:master.

@huyuxin0429 huyuxin0429 force-pushed the feature_sort_max_and_avg_similarity_first branch from 11957a0 to f268a31 Compare November 12, 2023 14:50
@huyuxin0429 huyuxin0429 force-pushed the feature_sort_max_and_avg_similarity_first branch from f268a31 to f39a3e0 Compare November 12, 2023 14:54
@huyuxin0429 huyuxin0429 merged commit b91b8a8 into WING-NUS:master Nov 12, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature A suggested idea for this project
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants