-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow floating social icons on two-column and other post templates #1102
Allow floating social icons on two-column and other post templates #1102
Conversation
Questions:
|
do we need any additional styling for this to make sure it gets positioned correctly? wasn't the reason we pulled it originally because it was appearing over the content in some cases? |
as far as i know there are no child themes we host, using 0.5.4, that alter the overall page width from the 1170px default |
i WOULD like to take a quick look at this on staging though, for all of the sites using the two column layout |
It was a worry. I've checked this against posts in themes with different single templates:
There haven't been any problems so far. The buttons are positioned outside the main page container div, so there haven't been conflicts. |
…are-buttons Allow floating social icons on two-column and other post templates
Changes
largo_floating_social_button_width_json
, to increase the minimum width of viewport needed for the floating social buttons when using a template other than Largo's single-column template1
times the width of the floating social buttons to0.7
times the width of the floating social buttonsWhy
For NPQ and VO-10, because we removed the sticky footer in 0.5.4.