Remove INN/Largo Project Google Analytics tracking from Largo. #1502
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
largo_google_analytics()
so that Google Analytics is only loaded if the site has configured a Google Analytics ID in the Largo theme options.largo_google_analytics()
Why
Well, for starters, privacy and as part of #1495 "what do we need to do for WordPress 4.9.6 and the GDPR?" question. And also because removing GA increases page speed.
But also because this always-on Google Analytics sometimes conflicts with other Google Analytics tags. It's an older tag, and it doesn't check out.
This solution shouldn't conflict with INN/umbrella-rivard-report#30 or similar child theme changes that
remove_action( 'wp_head', 'largo_google_analytics' );
.Questions
of_get_option()
comparison safe?post-merge todo: