Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove INN/Largo Project Google Analytics tracking from Largo. #1502

Merged
merged 5 commits into from
Nov 7, 2018

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Jul 17, 2018

Changes

  • removes the Google Analytics tracking of INN Members
  • removes the Google Analytics tracking of all Largo users
  • changes the logic within largo_google_analytics() so that Google Analytics is only loaded if the site has configured a Google Analytics ID in the Largo theme options.
  • minor code cleanup within largo_google_analytics()

Why

Well, for starters, privacy and as part of #1495 "what do we need to do for WordPress 4.9.6 and the GDPR?" question. And also because removing GA increases page speed.

But also because this always-on Google Analytics sometimes conflicts with other Google Analytics tags. It's an older tag, and it doesn't check out.

download

This solution shouldn't conflict with INN/umbrella-rivard-report#30 or similar child theme changes that remove_action( 'wp_head', 'largo_google_analytics' );.

Questions

  • is that of_get_option() comparison safe?
  • does this need docs for anything? Is it just something that we'll just add to the changelog?
  • are there tests that are affected?

post-merge todo:

  • add to changelog
  • figure out how we're going to request/acquire lists of Largo-using sites in the future.

@benlk benlk added the priority: normal Must be completed before release of this version of plugin. label Jul 17, 2018
@benlk benlk added this to the 0.6 - Performance & SEO milestone Jul 17, 2018
@benlk benlk self-assigned this Jul 17, 2018
@benlk benlk requested a review from a team July 17, 2018 14:33
@benlk
Copy link
Collaborator Author

benlk commented Nov 7, 2018

figure out how we're going to request/acquire lists of Largo-using sites in the future.

That continues in #1495.

@benlk benlk merged commit 175ea20 into 0.5-dev Nov 7, 2018
@benlk benlk deleted the 1495-remove-ga-inn-largo branch November 7, 2018 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal Must be completed before release of this version of plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant