Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require_once normalization #1589

Merged
merged 3 commits into from
Apr 19, 2019
Merged

require_once normalization #1589

merged 3 commits into from
Apr 19, 2019

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Dec 7, 2018

Changes

  • uses vaidate_file() when using require_once
  • reviews includes and requires

Why

For #1494

@benlk benlk mentioned this pull request Dec 7, 2018
Closed
2 tasks
@benlk benlk added this to the 0.6.2 milestone Dec 7, 2018
@benlk benlk added type: improvement priority: normal Must be completed before release of this version of plugin. type: tech debt For necessary updates because code is old labels Dec 7, 2018
@benlk benlk mentioned this pull request Dec 7, 2018
Open
@benlk benlk modified the milestones: 0.6.2, 0.6.3 Dec 19, 2018
@benlk benlk modified the milestones: 0.6.3, 0.6.2 Apr 18, 2019
@benlk benlk merged commit f692d8b into 0.5-dev Apr 19, 2019
@benlk benlk deleted the 1494-require-onces branch April 19, 2019 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
priority: normal Must be completed before release of this version of plugin. type: improvement type: tech debt For necessary updates because code is old
Projects
None yet
Milestone
0.6.2
Development

Successfully merging this pull request may close these issues.
1 participant
@benlk