Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Largo_Related tests and bugfixes #842

Merged
merged 16 commits into from
Aug 17, 2015
Merged

Largo_Related tests and bugfixes #842

merged 16 commits into from
Aug 17, 2015

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Aug 17, 2015

Changes

Largo_Related now uses the correct query to catch series landing pages.

Tests for Largo_Related's:

  • ::__construct()
  • ::popularity_sort()
  • ::ids() in the following conditions:
    • unorganized series with a post published before the current post
    • unorganized series with a post published after the current post
    • a series with a landing page forcing the ascending sort order
    • a series with a landing page forcing the descending sort order
    • a series with a landing page forcing the custom sort order
    • a series with a landing page forcing descending sort order, with featured posts
    • a series with a landing page forcing ascending sort order, with featured posts
    • a category with posts
    • a tag
    • the current post matches posts in both categories and tags, with results drawn from both
    • no posts in the same series, categories, or tags, so only recent posts should be returned.
  • ::cleanup_ids()

Why

Largo_Related bugfixes for #841, Test coverage for #782.

rnagle added a commit that referenced this pull request Aug 17, 2015
@rnagle rnagle merged commit bf748ac into develop Aug 17, 2015
@benlk
Copy link
Collaborator Author

benlk commented Aug 17, 2015

a series with a landing page forcing descending sort order, with featured posts
a series with a landing page forcing ascending sort order, with featured posts

These tests fail because the featured post is being returned last in the order, not first. They're marked incomplete. This may be because of a bug in the test, in Largo_Related, or in inc/wp-taxonomy-landing/functions/cftl-series-order.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants