-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dynamic social buttons #943
Conversation
… dynamic share buttons anymore
does this affect the twitter/fb follow widgets? seems like it might. I'm ok with killing those but some sites are pretty wedded to them, the twitter one, particularly. we'll probably need some kind of plan to deal with that if we do nuke them. |
… twitter and fb follow widgets
@aschweigert Yeah, it definitely does affect the twitter and fb widgets. Didn't realize that at first. I added the required scripts back. Kind of a bummer that we need to load these, but still think we're doing a good thing by not requiring the JS to power the dynamic share buttons. |
<?php | ||
// Are the widgets that contain facebook social buttons loaded (or are we on single/author?) | ||
if( largo_facebook_widget::is_rendered() || largo_follow_widget::is_rendered() || is_single() || is_author() ) : ?> | ||
if( largo_facebook_widget::is_rendered() || largo_follow_widget::is_rendered() || is_single() || is_author() ) : ?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the checks for is_single()
and is_author()
here if the scripts are no longer used as a result of the page being an author or single page?
Tests pass and the buttons work. I have couple questions on the enqueueing made in comments on the diff. It's a minor issue, but the Print button in the post-header social media buttons doesn't use the 'pointer' cursor used for the other links. This is understandable, because it doesn't have an |
…es to the share icons on hover
See #901.
This PR:
largo_show_twitter_count
since it's no longer relevant.largo_post_social_links
.