Crash when selecting a turret in the unit design screen

[wzdev-ci]

resolution_fixed type_bug | by info@...

---

Steps to reproduce: Go to unit design, select a body and propulsion, at least one of which needs a non-ascii character in its name, select a turret (possibly repeat the last step until the crash).

This is a strange problem. It doesn't happen (in an obvious way) on Linux, and it doesn't happen (so far) with the English language setting. It does happen on qt-trunk though (as well as 2.3.5, 3.0 and master). Happens in both skirmish and campaign. On Linux, it doesn't happen (so far) when the first turret is selected, it can take a dozen clicks (speed doesn't matter). On Windows, it seems to crash instantly in the campaign, but not skirmish. Possibly some memory corruption again...

---

Issue migrated from trac:2209 at 2022-04-16 06:39:52 -0700

[wzdev-ci]

info@... uploaded file Warzone2100.RPT (74.6 KiB)

[wzdev-ci]

info@... uploaded file netplay-0908_002535.log (1.6 KiB)

[wzdev-ci]

info@... uploaded file WZlog-0908_002535.txt (0.0 KiB)

[wzdev-ci]

anonymous uploaded file Warzone2100.2.RPT (3.5 KiB)

[wzdev-ci]

anonymous commented

---

Same here. Crashes with access violation at 77c?e1fe in ntdll.dll
Win7 x64

[wzdev-ci]

Buginator commented

---

Can you give any more information on how to replicate this ?

It looks like you both are not using English, but something else.

It also looks like you both are crashing after SDL_HasAltiVec() so it could also be a SDL bug of some type...

[wzdev-ci]

anonymous commented

---

Indeed, I'm playing the german version, since that's the one I'm most used to ^_^ I'll try replicating the crash on english when I have some spare time.

[wzdev-ci]

cybersphinx changed operating_system which not transferred by tractive

[wzdev-ci]

cybersphinx edited the issue description

[wzdev-ci]

cybersphinx changed title from Access Violation at location 0x######## in module C:\Windows\SysWOW64\ntdll.dll Reading from location 0x########. to Crash when selecting a turret in the unit design screen

[wzdev-ci]

cybersphinx changed priority from major to blocker

[wzdev-ci]

cybersphinx changed milestone from 2.3.x to 3.0

[wzdev-ci]

cybersphinx changed keywords from access violation ntdll.dll windows7 x64 to ``

[wzdev-ci]

cybersphinx commented

---

More reports: #2266, #2282, #2284.

[wzdev-ci]

cybersphinx uploaded file 2209-glibc-backtrace.txt (0.9 KiB)

glibc backtrace, not caught by the crash handler

[wzdev-ci]

cybersphinx uploaded file 2209-3.0-gdb.txt (6.9 KiB)

gdb backtrace from 3.0, German

[wzdev-ci]

cybersphinx uploaded file 2209-3.0-chinese.txt (23.0 KiB)

gdb backtrace from 3.0, Chinese

[wzdev-ci]

cybersphinx uploaded file 2209-qt-trunk.txt (12.3 KiB)

gdb backtrace from qt-trunk, German

[wzdev-ci]

cybersphinx edited the issue description

[wzdev-ci]

R3act!ve commented

---

Campaign is definitive unplayable (untestable) whit this bug.

Main reason is the flamer turret. Replicable.

Sometimes there are also random crashes if you click on any button in the design menu.
I didn´t found a reason why. Not replicable.

[wzdev-ci]

cybersphinx uploaded file valgrind.out (18.2 KiB)

Valgrind run of 6f5392f14947f0c44cedd40165031f4eb4a819a7. Of course the problem itself didn't occur, but maybe the invalid read/writes are the cause.

[wzdev-ci]

cybersphinx commented

---

Some bisecting was more successful, and indicates 81f07188a3693007621496ac9fa0c0e2e8b24b87. Now we get crashes instead of "error |05:10:12: [iV_GetCharWidth] Couldn't retrieve a bounding box for the character code 252". Well, at least we have some whiny guy on IRC to blame.

[wzdev-ci]

cybersphinx commented

---

Hm, and of course it was one of those "what could possibly happen?" commits that didn't even need another rc...

[wzdev-ci]

buginator <buginator@...> changed status from new to closed

[wzdev-ci]

buginator <buginator@...> changed resolution from `` to fixed

[wzdev-ci]

buginator <buginator@...> commented

---

(In Warzone2100/warzone2100@3012fde) CHANGELOG: Correctly handle unicode strings for edit boxes.

fixes #2209

[wzdev-ci]

buginator <buginator@...> commented

---

In Warzone2100/warzone2100@3012fde:

#CommitTicketReference repository="" revision="3012fde61ef92151e0ec5125551a7b3481f05fb8"
CHANGELOG: Correctly handle unicode strings for edit boxes.

fixes #2209

[wzdev-ci]

Per Inge Mathisen <per@...> commented

---

(In Warzone2100/warzone2100@209e12b) CHANGELOG: Correctly handle unicode strings for edit boxes.

fixes #2209

[wzdev-ci]

Per Inge Mathisen <per@...> commented

---

In Warzone2100/warzone2100@209e12b:

#CommitTicketReference repository="" revision="209e12b665d23cce1cf286435ace08b86250517b"
CHANGELOG: Correctly handle unicode strings for edit boxes.

fixes #2209

[wzdev-ci]

buginator <buginator@...> commented

---

(In Warzone2100/warzone2100@5a35eb9) CHANGELOG: Correctly handle unicode strings for edit boxes.

fixes #2209
(cherry picked from commit 3012fde61ef92151e0ec5125551a7b3481f05fb8)

Conflicts:

lib/widget/editbox.c

[wzdev-ci]

buginator <buginator@...> commented

---

In Warzone2100/warzone2100@5a35eb9:

#CommitTicketReference repository="" revision="5a35eb9f89b1d24bcc7abd58094e67496de5708e"
CHANGELOG: Correctly handle unicode strings for edit boxes.

fixes #2209
(cherry picked from commit 3012fde61ef92151e0ec5125551a7b3481f05fb8)

Conflicts:

	lib/widget/editbox.c

[wzdev-ci]

buginator commented

---

Don't try to render a string that is NULL. Unknown why this happens, need someone that has access to non-English systems to debug this matter more.

refs #2209
refs tickts:2245
(cherry picked from commit b6952c184456b999fb4dfd51ced072ca1b206740)

Conflicts:

lib/ivis_opengl/textdraw.c 

Changeset: 50aafb279edaed68251079ce463c83c46628d14b

[wzdev-ci]

buginator commented

---

CHANGELOG: Correctly handle unicode strings for edit boxes.

fixes #2209
(cherry picked from commit 3012fde61ef92151e0ec5125551a7b3481f05fb8)

Conflicts:

lib/widget/editbox.c 

Changeset: 5a35eb9f89b1d24bcc7abd58094e67496de5708e

[wzdev-ci]

buginator commented

---

Don't try to render a string that is NULL. Unknown why this happens, need someone that has access to non-English systems to debug this matter more.

refs #2209
refs tickts:2245
(cherry picked from commit b6952c184456b999fb4dfd51ced072ca1b206740)

Conflicts:

lib/ivis_opengl/textdraw.c 

Changeset: 50aafb279edaed68251079ce463c83c46628d14b

[wzdev-ci]

cybersphinx changed milestone from 3.0 to unspecified

[wzdev-ci]

cybersphinx commented

---

Milestone 3.0 deleted