Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added dbus bus and object paths getters #1392

Closed
wants to merge 4 commits into from
Closed

feat: added dbus bus and object paths getters #1392

wants to merge 4 commits into from

Conversation

RossComputerGuy
Copy link

Implemented methods to get the object paths for application menu and menubar. Also added a getter for the unique DBus name for wayfire_view. With this, it will be possible to implement Global Menu's. Ran tests via ninja, all succeeded.

@Nuc1eoN
Copy link

Nuc1eoN commented Jan 19, 2022

Can we get this merged?

@RossComputerGuy
Copy link
Author

I've been using the code from this repo in developing of my Wayfire based DE and I've had no issues with it. It's ready to go and has no bugs.

@ammen99
Copy link
Member

ammen99 commented Jan 19, 2022

I am currently working on fixing some design issues in Wayfire and adding some new features (see #1317). It would be a lot of work to keep merging PRs and constantly rebasing my work, and in the end we'll end up with a history of commits which don't even compile (I'm always rebasing instead of merging as I like the linear history we get this way). So, I have decided to temporarily not merge any PRs until the bigger changes are done and merged in master.

This applies to this and any other open PRs, even if they don't contain a lot of changes and seem to work.

Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, we can merge it now :)

@ammen99
Copy link
Member

ammen99 commented May 25, 2022

Does anyone know why the CI did not run for this PR?

@RossComputerGuy
Copy link
Author

image

I'm not sure why its not running.

@ExpidusOS-archive ExpidusOS-archive closed this by deleting the head repository Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants