Skip to content

Conversation

bernardoasc
Copy link
Member

Web Dev Path
issueNumber

Have you updated the CHANGELOG.md file? If not, please do it.
Yes

What is this change?
Release 1.3.0, tagging all features and fixes done in version 1.2.0 on GitHub.

Were there any complications while making this change?
No.

How did you verify this change?
Locally.

When should this be merged?
After review.

@bernardoasc bernardoasc linked an issue Jun 5, 2023 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Jun 5, 2023

Deploy Preview for priceless-booth-2dfcaf ready!

Name Link
🔨 Latest commit 700cec0
🔍 Latest deploy log https://app.netlify.com/sites/priceless-booth-2dfcaf/deploys/647e2b90cded3000088d172e
😎 Deploy Preview https://deploy-preview-172--priceless-booth-2dfcaf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bernardoasc bernardoasc requested review from cherylli and a team and removed request for cherylli June 5, 2023 18:41
Copy link
Member

@mariana-caldas mariana-caldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @bernardoasc !
Our repository has a rule that only allows merging a PR after the second approval, however, as admin, I can bypass that rule. I'm just waiting to see if we have any other reviews by EOD so you can merge it yourself, Bernardo 🙌🏼

@vmcodes
Copy link
Contributor

vmcodes commented Jun 7, 2023

LGTM! Thanks @bernardoasc ! Our repository has a rule that only allows merging a PR after the second approval, however, as admin, I can bypass that rule. I'm just waiting to see if we have any other reviews by EOD so you can merge it yourself, Bernardo 🙌🏼

Looks good to me.

@bernardoasc bernardoasc merged commit 83bb7d5 into main Jun 8, 2023
@bernardoasc bernardoasc deleted the 171-release-130 branch June 8, 2023 19:58
@mariana-caldas mariana-caldas mentioned this pull request Feb 9, 2025
@Satoshi-Sh Satoshi-Sh mentioned this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 1.3.0
3 participants