Skip to content

Normalizing project font sizes #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 30, 2022
Merged

Conversation

mariana-caldas
Copy link
Member

@mariana-caldas mariana-caldas commented Mar 29, 2022

Web Dev Path

Have you updated the CHANGELOG.md file? If not, please do it.

Yes.

What is this change?

  • Font sizes are being normalized throughout the project
  • The pages in development styling, such as "About Us" and "Contact Us", is being adjusted
  • The footer styling is being adjusted for smaller screens.

Were there any complications while making this change?

No.

How did you verify this change?

Locally and also taking a look at the Netlify deploy preview link.

When should this be merged?

After review.

@netlify
Copy link

netlify bot commented Mar 29, 2022

Deploy Preview for priceless-booth-2dfcaf ready!

Name Link
🔨 Latest commit e330124
🔍 Latest deploy log https://app.netlify.com/sites/priceless-booth-2dfcaf/deploys/6243c2ef6639c30008271b6b
😎 Deploy Preview https://deploy-preview-90--priceless-booth-2dfcaf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mariana-caldas mariana-caldas marked this pull request as ready for review March 30, 2022 00:15
@vmcodes
Copy link
Collaborator

vmcodes commented Mar 30, 2022

@mariana-caldas great PR and use of the sass variables already in place.

@mariana-caldas mariana-caldas merged commit 659afda into master Mar 30, 2022
@mariana-caldas mariana-caldas deleted the chore/normalize-font-sizes branch March 30, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants