[Stack Switching] Validate continuation function subtyping #7847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
Aug 20, 2025
src/wasm/wasm-validator.cpp
Outdated
Comment on lines
3982
to
3984
| if (!curr->type.isContinuation()) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Let's put the early return on a check for unreachable and then do a shouldBeTrue (with the error message below) to check for a continuation.
There was a problem hiding this comment.
Ah, there is already an unreachable if above. Fixed.
src/wasm/wasm-validator.cpp
Outdated
Comment on lines
3987
to
3989
| if (!shouldBeTrue(cont.type.isSignature(), | ||
| curr, | ||
| "cont.new must be annotated with a continuation type")) { |
There was a problem hiding this comment.
We can just assert that the continuation refers to a function type. It's impossible for the the type to have been successfully built otherwise.
tlively
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.