[NFC] Mark some DAE-internal passes as requiring less work #7858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Aug 27, 2025
| std::function<void(Function*)> onChange) { | ||
| struct LocalizerPass : public WalkerPass<PostWalker<LocalizerPass>> { | ||
| bool isFunctionParallel() override { return true; } | ||
| bool requiresNonNullableLocalFixups() override { return false; } |
There was a problem hiding this comment.
It would be good to add a comment about why this is true, i.e. // Always sets locals immediately before using them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The non-nullable overhead usually doesn't matter, but DAE can end up running
many internal pass iterations, many of whom are very lightweight otherwise,
so this adds up.
On a dart testcase I see, this makes DAE (the slowest pass there) 7% faster.
Helps #4165