[Stack Switching] wasm-ctor-eval: Do not try to serialize continuations #7877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
Sep 3, 2025
There was a problem hiding this comment.
It would be good to test the non-serializable defining global, parameter, and local separately.
Co-authored-by: Thomas Lively <tlively123@gmail.com>
tlively
approved these changes
Sep 3, 2025
Co-authored-by: Thomas Lively <tlively123@gmail.com>
kripken
added a commit
that referenced
this pull request
Sep 5, 2025
…ization errors in results (#7883) #7877 gave up when we couldn't serialize things, in various situations. But one of the cases, when we can't serialize the results, we checked AFTER we already "commit" the changes to the module. That is, we need to check for errors and stop if we find any, and only then apply execution results to the module, and we added a check that was after the application. To fix this, we need to be careful and know that if we will care about the serialization of the results then we cannot execute continuations, as they may end up needing to be serialized. Doing anything more precise would be significantly more complex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They cannot be serialized.
This requires us to be able to "give up" when any serialization fails, adding
various code paths for that.