[Custom Descriptors] Fuzz ref.cast_desc and ref.get_desc #7913
+37
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
Sep 22, 2025
src/tools/fuzzing/fuzzing.cpp
Outdated
| // create one if that type would fit |type| which is what we must emit at the | ||
| // end. | ||
| Expression* descRef = nullptr; | ||
| if (auto desc = refType.getHeapType().getDescriptorType(); |
There was a problem hiding this comment.
The descriptor type is tied to the cast output type, so I believe this could be auto desc = type.getHeapType().getDescriptorType(). Then we wouldn't have to check that refType <: type below and could emit it no matter what the relationship between type and refType.
tlively
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.