Skip to content

[Custom Descriptors] Optimize descriptors in Unsubtyping #7929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 2, 2025
Merged

[Custom Descriptors] Optimize descriptors in Unsubtyping #7929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
deca26f
[Custom Descriptors] Optimize descriptors in Unsubtyping
tlively Sep 29, 2025
58dbd93
superytpe
tlively Sep 29, 2025
06f8b60
requiresNonNullableLocalFixups comment
tlively Sep 29, 2025
752061c
generalize
tlively Sep 30, 2025
159f680
handle soon-to-be-invalid types
tlively Sep 30, 2025
2dde94d
preserve traps
tlively Sep 30, 2025
7e6d093
missing super call
tlively Sep 30, 2025
2ec9a0e
nested allocations to new globals
tlively Sep 30, 2025
2b0df59
missing period and better names
tlively Oct 1, 2025
6559430
Merge branch 'main' into unsubtyping-optimize-descs
tlively Oct 1, 2025
4234962
Merge branch 'main' into unsubtyping-optimize-descs
tlively Oct 1, 2025
7f02e04
diagram consistency
tlively Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/ir/subtype-exprs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,8 +311,16 @@ struct SubtypingDiscoverer : public OverriddenVisitor<SubType> {
void visitRefCast(RefCast* curr) { self()->noteCast(curr->ref, curr); }
void visitRefGetDesc(RefGetDesc* curr) {}
void visitBrOn(BrOn* curr) {
if (curr->op == BrOnCast || curr->op == BrOnCastFail) {
self()->noteCast(curr->ref, curr->castType);
switch (curr->op) {
case BrOnNull:
case BrOnNonNull:
break;
case BrOnCast:
case BrOnCastFail:
case BrOnCastDesc:
case BrOnCastDescFail:
self()->noteCast(curr->ref, curr->castType);
break;
}
self()->noteSubtype(curr->getSentType(),
self()->findBreakTarget(curr->name));
Expand Down
Loading
Loading