Fuzzer: Pick an interesting function type for our functions #7936
+27
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
Oct 1, 2025
| } | ||
| auto paramType = Type(params); | ||
| auto resultType = getControlFlowType(); | ||
| funcType = Signature(paramType, resultType); |
There was a problem hiding this comment.
Could also choose whether to make the new type open or not independently, but maybe it's not worth the effort.
There was a problem hiding this comment.
Yeah, I think it's ok to leave that part to the interesting heap types. Here we just create the simplest MVP-style type.
tlively
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we always made a new, simple (closed, and not a subtype of
anything) type. Now we pick an interesting one sometimes.
In particular, sometimes we'll get an open type here, allowing #7935
to do more (as it can only optimize DAE results on an open type).