Fuzzer: Add support to --fuzz-exec two files #7947
Merged
+112
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Oct 4, 2025
| LoggingExternalInterface interface(loggings, wasm); | ||
| // Get results of executing a module. Optionally, provide a second module to | ||
| // link with it (like fuzz_shell's second module). | ||
| void get(Module& wasm, Module* second = nullptr) { |
There was a problem hiding this comment.
Kind of weird to have a void return on a function called get, but I guess that's not directly related to this PR.
There was a problem hiding this comment.
Hmm, yeah, maybe this could be renamed to "gather" or "collect".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fuzz_shell.jsalready allows linking in a second file from JS. This does the same forwasm-opt's
--fuzz-exec-beforefunctionality.To do that, track linked instances in execution results, and link and run
a second module there, if provided.
This will be useful in fuzzing cross-module code, which we atm do in
V8, but running in our interpreter will use our own assertions.