Skip to content

[NFC] Remove unnecessary std::optional in FuncData #7950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
Merged

[NFC] Remove unnecessary std::optional in FuncData #7950

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/wasm-interpreter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,11 +142,9 @@ struct FuncData {

// A way to execute this function. We use this when it is called.
using Call = std::function<Flow(Literals)>;
std::optional<Call> call;
Call call;

FuncData(Name name,
void* self = nullptr,
std::optional<Call> call = std::nullopt)
FuncData(Name name, void* self = nullptr, Call call = {})
: name(name), self(self), call(call) {}

bool operator==(const FuncData& other) const {
Expand All @@ -155,7 +153,7 @@ struct FuncData {

Flow doCall(Literals arguments) {
assert(call);
return (*call)(arguments);
return call(arguments);
}
};

Expand Down
Loading