Add some language identifier to enable syntax highlighting #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for adding this! We have a little bit of a chicken and egg problem where WIT is defined by this repo but the grammar is specified in bytecodealliance/vscode-wit. The linguist tool used by GitHub for code blocks rendering in md pulls the grammar from that repo. I think this can be OK so long as it is clear that there will be a lag between incoming changes to WIT syntax and when rendering for the new syntax is supported. I noticed that this change does not add language identifiers for all code blocks, e.g. there are many more blocks in |
|
lgtm, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some language identifiers to code block for enabling syntax highlighting. :)