Skip to content

Check all types of partially-oob stores #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2021
Merged

Check all types of partially-oob stores #1385

merged 2 commits into from
Oct 28, 2021

Conversation

ngzhian
Copy link
Member

@ngzhian ngzhian commented Oct 27, 2021

Follow-up to #1384 to add checks for all numeric type.

Fixes #1250.

@ngzhian
Check all types of partially-oob stores
8309729 
Follow-up to WebAssembly#1384 to add checks for all numeric type.

Fixes WebAssembly#1250.
@ngzhian ngzhian requested a review from lars-t-hansen October 27, 2021 17:54
lars-t-hansen
lars-t-hansen approved these changes Oct 28, 2021
View reviewed changes
Copy link

@lars-t-hansen lars-t-hansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ngzhian ngzhian merged commit 93054e7 into WebAssembly:main Oct 28, 2021
@ngzhian ngzhian deleted the more-oob-store branch October 28, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lars-t-hansen lars-t-hansen lars-t-hansen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[test] Missing test cases that partially-oob stores do not store partial data

2 participants

@ngzhian @lars-t-hansen