Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wasm2c status for extended-const and simd #334

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Update wasm2c status for extended-const and simd #334

merged 1 commit into from
Jul 12, 2023

Conversation

keithw
Copy link
Member

@keithw keithw commented May 12, 2023

No description provided.

@keithw
Copy link
Member Author

keithw commented Jun 20, 2023

Bump if anybody is able to take a look at this.

@keithw
Copy link
Member Author

keithw commented Jul 12, 2023

@dschuff @sbc100 Are you able to take a look at this one? Would be nice to get this closed off. Thanks in advance.

"memory64": ["flag", "Requires flag `--enable-memory64`"],
"multiMemory": ["flag", "Requires flag `--enable-multi-memory`"],
"multiValue": "1.0.24",
"mutableGlobals": "1.0.1",
"referenceTypes": "1.0.31",
"saturatedFloatToInt": "1.0.24",
"signExtensions": "1.0.24",
"simd": false
"simd": "1.0.33"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it not require a flag?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't require a flag (SIMD was enabled by default in WABT shortly after it went to phase 5). But, wasm2c only puts SIMD support in the generated output if the module actually uses it, since it's a ton of code...

@dschuff
Copy link
Member

dschuff commented Jul 12, 2023

Sorry I missed this, thanks for bumping!

@dschuff dschuff merged commit e1dadef into WebAssembly:main Jul 12, 2023
@keithw keithw deleted the wasm2c-1033 branch July 12, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants