Fix #12 by adding outputTimeStamp attribute to AudioDestinationNode #754

pozdnyakov · 2016-03-08T11:59:18Z

This patch introduces 'AudioDestinationNode.outputTimeStamp'
and 'AudioDestinationNode.outpuLatency' attributes, so that it's possible
to estimate when the given context's stream position is audible.

rtoy · 2016-03-08T17:07:57Z

index.html

+            </p>
+          </dd>
+          <dt>
+            AudioTimestamp&lt;void&gt; getPosition()


getPosition seems rather vague. Is there a better name?

Would getStreamPosition be better?

…ribute The newly added 'AudioDestinationNode.devicePosition' attribute helps to bind audio context time and performance time values. Please see for more details: WebAudio/web-audio-api#754 WebAudio/web-audio-api#12

padenot · 2016-04-15T10:12:13Z

index.html

+            </p>
+            <p>
+              The <a><code>latency</code></a> attribute value depends on the
+              platform and it does not change for the context's lifetime.


What happens if you unplug your usb device ? This changes the sound card and probably changes the latency as well. Same think if you disconnect an bluetooth device that is using a2ps, you go from 400+ms to low latency.

The attribute value should change in this case indeed, I'll update the description accordingly.. Thanks for pointing it out.

…ribute The newly added 'AudioDestinationNode.devicePosition' attribute helps to bind audio context time and performance time values. Please see for more details: WebAudio/web-audio-api#754 WebAudio/web-audio-api#12

pozdnyakov · 2016-04-20T08:38:16Z

@padenot does it look OK now?

rtoy · 2016-04-20T16:13:27Z

index.html

@@ -2309,6 +2309,112 @@ <h2 id="AudioDestinationNode">
              not be changed.
            </p>
          </dd>
+          <dt>
+            readonly attribute double latency


Since we also now have baseLatency (for the playback category stuff), latency is, perhaps, too generic. Maybe outputLatency, or deviceOutputLatency, or something else?

We already have the baseLatency in the context, this needs to be moved to there. Getting two different latency values from different entities is weird. Also this should be renamed - I prefer deviceOutputLatency.

I'd prefer outputLatency as it matches to outputTimeStamp in the latest patch. IMO outputLatency should remain at AudioDestinationNode as this interface is representing an output device, so it's a natural place to contain the attribute representing output device latency. wdyt?

…'AudioDestinationNode.outputLatency' This patch introduces 'AudioDestinationNode.outputTimeStamp' and 'AudioDestinationNode.outputLatency' attributes, so that it's possible to estimate when the given context's stream position is audible.

pozdnyakov · 2016-05-11T08:25:28Z

All checks have passed successfully, @rtoy could it be merged or we're still waiting for some input?

rtoy · 2016-05-11T15:30:04Z

I would still like someone else to review it too. Still lgtm from me of
course.

On Wed, May 11, 2016 at 1:25 AM, Mikhail Pozdnyakov <
notifications@github.com> wrote:

All checks have passed successfully, @rtoy https://github.com/rtoy
could it be merged or we're still waiting for some input?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#754 (comment)

Ray

padenot · 2016-05-12T12:12:53Z

I just re-read everything, I think the text is good now.

…ribute The newly added 'AudioDestinationNode.devicePosition' attribute helps to bind audio context time and performance time values. Please see for more details: WebAudio/web-audio-api#754 WebAudio/web-audio-api#12

…ribute The newly added 'AudioDestinationNode.devicePosition' attribute helps to bind audio context time and performance time values. Please see for more details: WebAudio/web-audio-api#754 WebAudio/web-audio-api#12 For M51 rebase adapted to, https://codereview.chromium.org/1773813007

This reverts the following commits: * 2b2cbc8 ("[Windows] Implementation of 'AudioDestinationNode.devicePosition' attribute") * 43d41bf ("Fix calling of AudioOutputStream::AudioSourceCallback API") * fd8c95a ("Remove unused private field device_position_") This code was added when Crosswalk was being used as an alternative implementation for some changes to the WebAudio spec: * WebAudio/web-audio-api#12 * WebAudio/web-audio-api#754 The spec has since been changed and upstream Chromium is being adapted, so there is no need to keep these patches in Crosswalk any longer. Additionally, this code in its present form has caused serious regressions in WebRTC support (the WebRTC Crosswalk sample did not produce any sound). Thanks to Michael Walton <mike@farsouthnet.com> for the investigation leading to this commit. BUG=XWALK-7030 BUG=XWALK-7225

This reverts the following commits in the crosswalk-22/52.0.2743.116 branch: * 2b2cbc8 ("[Windows] Implementation of 'AudioDestinationNode.devicePosition' attribute") * 43d41bf ("Fix calling of AudioOutputStream::AudioSourceCallback API") This code was added when Crosswalk was being used as an alternative implementation for some changes to the WebAudio spec: * WebAudio/web-audio-api#12 * WebAudio/web-audio-api#754 The spec has since been changed and upstream Chromium is being adapted, so there is no need to keep these patches in Crosswalk any longer. Additionally, this code in its present form has caused serious regressions in WebRTC support (the WebRTC Crosswalk sample did not produce any sound). Thanks to Michael Walton (mike@farsouthnet.com) for the investigation leading to this commit. BUG=XWALK-7030 BUG=XWALK-7226 (cherry picked from commit 7807ac7)

This reverts the following commits in the crosswalk-21/51.0.2704.106 branch: * e230a89 ("[Windows] Implementation of 'AudioDestinationNode.devicePosition' attribute") * a0388f7 ("Fix calling of AudioOutputStream::AudioSourceCallback API") This code was added when Crosswalk was being used as an alternative implementation for some changes to the WebAudio spec: * WebAudio/web-audio-api#12 * WebAudio/web-audio-api#754 The spec has since been changed and upstream Chromium is being adapted, so there is no need to keep these patches in Crosswalk any longer. Additionally, this code in its present form has caused serious regressions in WebRTC support (the WebRTC Crosswalk sample did not produce any sound). Thanks to Michael Walton (mike@farsouthnet.com) for the investigation leading to this commit. BUG=XWALK-7030 BUG=XWALK-7226 (cherry picked from commit 7807ac7)

…ribute The newly added 'AudioDestinationNode.devicePosition' attribute helps to bind audio context time and performance time values. Please see for more details: WebAudio/web-audio-api#754 WebAudio/web-audio-api#12 For M51 rebase adapted to, https://codereview.chromium.org/1773813007

padenot mentioned this pull request Mar 8, 2016

Fix #12 by adding attributes for performance timestamps and output la… #677

Closed

rtoy reviewed Mar 8, 2016
View reviewed changes

pozdnyakov force-pushed the 12-dest-node-get-position branch from a20fe47 to e39359d Compare March 9, 2016 16:11

pozdnyakov mentioned this pull request Mar 23, 2016

[Windows] Implementation of 'AudioDestinationNode.devicePosition' att… crosswalk-project/chromium-crosswalk#332

Merged

pozdnyakov force-pushed the 12-dest-node-get-position branch from e39359d to 11f1264 Compare March 23, 2016 19:19

pozdnyakov mentioned this pull request Mar 29, 2016

[Windows] Implementation of 'AudioDestinationNode.devicePosition' att… crosswalk-project/chromium-crosswalk#333

Closed

pozdnyakov changed the title ~~Fix #12 by by adding getPosition() method to AudioDestinationNode~~ Fix #12 by by adding devicePosition attribute to AudioDestinationNode Apr 12, 2016

pozdnyakov mentioned this pull request Apr 12, 2016

Need a way to determine AudioContext time of currently audible signal #12

Closed

pozdnyakov changed the title ~~Fix #12 by by adding devicePosition attribute to AudioDestinationNode~~ Fix #12 by adding devicePosition attribute to AudioDestinationNode Apr 12, 2016

padenot reviewed Apr 15, 2016
View reviewed changes

pozdnyakov force-pushed the 12-dest-node-get-position branch from 11f1264 to 668ebb7 Compare April 15, 2016 11:24

rtoy reviewed Apr 20, 2016
View reviewed changes

pozdnyakov force-pushed the 12-dest-node-get-position branch from 792a039 to 7177196 Compare May 11, 2016 06:58

padenot merged commit 1c6778b into WebAudio:gh-pages May 12, 2016

hoch mentioned this pull request May 19, 2016

Property ownership of outputTimeStamp and outputLatency #817

Closed

rakuco mentioned this pull request Oct 5, 2016

Revert AudioDestinationNode.devicePosition commits crosswalk-project/chromium-crosswalk#388

Merged

rakuco mentioned this pull request Oct 5, 2016

crosswalk-22: Revert AudioDestinationNode.devicePosition commits crosswalk-project/chromium-crosswalk#389

Merged

rakuco mentioned this pull request Oct 5, 2016

crosswalk-21: Revert AudioDestinationNode.devicePosition commits crosswalk-project/chromium-crosswalk#390

Merged

meshula mentioned this pull request Apr 19, 2019

Add synchronization facilities? LabSound/LabSound#50

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #12 by adding outputTimeStamp attribute to AudioDestinationNode #754

Fix #12 by adding outputTimeStamp attribute to AudioDestinationNode #754

pozdnyakov commented Mar 8, 2016 •

edited

Loading

rtoy Mar 8, 2016

pozdnyakov Mar 9, 2016

padenot Apr 15, 2016

pozdnyakov Apr 15, 2016

pozdnyakov commented Apr 20, 2016

rtoy Apr 20, 2016

hoch Apr 20, 2016

pozdnyakov Apr 21, 2016

pozdnyakov commented May 11, 2016

rtoy commented May 11, 2016

padenot commented May 12, 2016

Fix #12 by adding outputTimeStamp attribute to AudioDestinationNode #754

Fix #12 by adding outputTimeStamp attribute to AudioDestinationNode #754

Conversation

pozdnyakov commented Mar 8, 2016 • edited Loading

rtoy Mar 8, 2016

Choose a reason for hiding this comment

pozdnyakov Mar 9, 2016

Choose a reason for hiding this comment

padenot Apr 15, 2016

Choose a reason for hiding this comment

pozdnyakov Apr 15, 2016

Choose a reason for hiding this comment

pozdnyakov commented Apr 20, 2016

rtoy Apr 20, 2016

Choose a reason for hiding this comment

hoch Apr 20, 2016

Choose a reason for hiding this comment

pozdnyakov Apr 21, 2016

Choose a reason for hiding this comment

pozdnyakov commented May 11, 2016

rtoy commented May 11, 2016

padenot commented May 12, 2016

pozdnyakov commented Mar 8, 2016 •

edited

Loading