Skip to content

Update multiview implementation to use OVR_multiview2 #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2019
Merged

Update multiview implementation to use OVR_multiview2 #32

merged 1 commit into from
Apr 24, 2019

Conversation

fernandojsg
Copy link
Contributor

Adapt the code from multiview to support the latest spec: https://www.khronos.org/registry/webgl/extensions/OVR_multiview2/

kenrussell
kenrussell approved these changes Apr 24, 2019
View reviewed changes
Copy link
Member

@kenrussell kenrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Has this been tested on a user agent supporting the WebGL version of GL_OVR_multiview2?

@fernandojsg
Copy link
Contributor Author

@kenrussell I've been testing it on canary and it works as expected

@kenrussell
Copy link
Member

Thanks for confirming. Merging.

@kenrussell kenrussell merged commit 91d806c into WebGLSamples:master Apr 24, 2019
@fernandojsg fernandojsg deleted the ovr_multiview2 branch April 24, 2019 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenrussell kenrussell kenrussell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fernandojsg @kenrussell