Skip to content

Improve runner code #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 14, 2025
Merged

Improve runner code #134

merged 2 commits into from
Aug 14, 2025

Conversation

camillobruni
Copy link
Contributor

@camillobruni camillobruni commented Aug 14, 2025 •
edited
Loading

  • Run benchmark code in blocks where possible to limit variable visibility
  • Use more const and remove var statements
  • Pass iterations to new Benchmark
  • Pass current iteration to benchmark.runIteration

@netlify Netlify
Copy link

netlify bot commented Aug 14, 2025 •
edited
Loading

✅ Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit bf9a2b4
🔍 Latest deploy log https://app.netlify.com/projects/webkit-jetstream-preview/deploys/689d9508878b3900083897fb
😎 Deploy Preview https://deploy-preview-134--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@camillobruni camillobruni changed the title Reduce global vars Improve runner code Aug 14, 2025
@camillobruni camillobruni requested a review from danleh August 14, 2025 07:52
danleh
danleh approved these changes Aug 14, 2025
View reviewed changes
Copy link
Contributor

@danleh danleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We are not using the total iteration count (passed to the Benchmark ctor) or current iteration (passed to runIteration) right now, but will in the future, correct?

@camillobruni
Copy link
Contributor Author

Correct, this has no effect currently, but I've started using them in the newer JS workloads, so I might land this separately for easier reviewing.

@camillobruni camillobruni merged commit c6524e8 into WebKit:main Aug 14, 2025
10 checks passed
@camillobruni camillobruni deleted the 2025-08-13_fewer_globals branch August 14, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danleh danleh danleh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camillobruni @danleh