Disable HashSet-wasm #140
Merged
Disable HashSet-wasm #140
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
camillobruni
approved these changes
Aug 14, 2025
|
Removing this sounds good to me. |
|
Set to disabled for now, in case we want to track this on internal CIs or so. Removing/cleanup later is easy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had discussed removing this workload a couple of months ago, but wanted to wait for more Wasm workloads to land. Now we can, I think. Disabling this also lowers the Wasm proportion of the total score.
Reasons: It's not realistic at all (it basically inserts elements in a HashSet ~8000 times; the two
addinstantiations account for ~75% of the CPU samples, see screenshot and symbol map), over-incentivizes inlining, and we have better workloads now. E.g., if we care about general datastructures implemented in Wasm, the sqlite workload is much larger, comes from an upstream benchmark suite, and exercises more diverse code.We could also completely remove instead of disabling it, but I went for the conservative option for now.
We could also remove
gcc-loops-wasmandquicksort-wasm, which are also quite microbenchmarky.WDYT? @kmiller68 @eqrion @iainireland
gcc-loops-wasmandquicksort-wasm?