-
Notifications
You must be signed in to change notification settings - Fork 1.7k
InsertParagraph should insert a BR when the root editable element is a phrasing content #10065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash 850abe4) |
whsieh
approved these changes
Feb 14, 2023
EWS run on previous version of this PR (hash 887dc38) |
nt1m
reviewed
Feb 14, 2023
EWS run on current version of this PR (hash 7195bf0)
|
…a phrasing content https://bugs.webkit.org/show_bug.cgi?id=252219 Reviewed by Wenson Hsieh. When the root editable element only allows phrasing content (e.g. span) then execCommand('insertParagraph') should insert a br instead of a div. * LayoutTests/editing/inserting/insert-paragraph-separator-phrasing-editable-root-expected.txt: Added. * LayoutTests/editing/inserting/insert-paragraph-separator-phrasing-editable-root.html: Added. * LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=normal&display=block&method=enter-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=normal&display=block&method=shift-enter-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=normal&display=list-item&method=enter-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=normal&display=list-item&method=shift-enter-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre&display=block&method=enter-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre&display=block&method=shift-enter-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre&display=list-item&method=enter-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre&display=list-item&method=shift-enter-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre-line&display=block&method=enter-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre-line&display=block&method=shift-enter-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre-line&display=list-item&method=enter-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre-line&display=list-item&method=shift-enter-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre-wrap&display=block&method=enter-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre-wrap&display=block&method=shift-enter-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre-wrap&display=list-item&method=enter-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/other/insertparagraph-in-inline-editing-host.tentative_white-space=pre-wrap&display=list-item&method=shift-enter-expected.txt: * Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp: (WebCore::isPhrasingContent): (WebCore::isEditableRootPhrasingContent): (WebCore::InsertParagraphSeparatorCommand::doApply): Canonical link: https://commits.webkit.org/260242@main
7195bf0
to
37c9962
Compare
Committed 260242@main (37c9962): https://commits.webkit.org/260242@main Reviewed commits have been landed. Closing PR #10065 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
37c9962
7195bf0
🧪 api-gtk