Add CSS Rhythmic Sizing as valid category in CSSProperties.json #10106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nt1m
approved these changes
Feb 14, 2023
|
EWS run on previous version of this PR (hash a63516c) |
|
No reviewer information in commit message, blocking PR #10106 |
sammygill
force-pushed
the
eng/rhythmic-sizing-Add-CSS-Rhythmic-Sizing-as-valid-category-in-CSSProperties-json
branch
from
a63516c to
dd2014e
Compare
|
EWS run on current version of this PR (hash dd2014e)
|
https://bugs.webkit.org/show_bug.cgi?id=252256 rdar://105458547 Reviewed by Tim Nguyen. The CSS Rhythmic Sizing specification introduces various new properties related to vertical rhythm on pages. In order to implement any of these properties, the specification needs to be listed as a valid cateogry within the CSSProperties.json file. * Source/WebCore/css/CSSProperties.json: Canonical link: https://commits.webkit.org/260280@main
webkit-early-warning-system
force-pushed
the
eng/rhythmic-sizing-Add-CSS-Rhythmic-Sizing-as-valid-category-in-CSSProperties-json
branch
from
dd2014e to
7dbe702
Compare
|
Committed 260280@main (7dbe702): https://commits.webkit.org/260280@main Reviewed commits have been landed. Closing PR #10106 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
sammygill
deleted the
eng/rhythmic-sizing-Add-CSS-Rhythmic-Sizing-as-valid-category-in-CSSProperties-json
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7dbe702
dd2014e
🛠 wincairo🧪 ios-wk2🧪 gtk-wk2🧪 api-ios🧪 api-gtk🧪 mac-AS-debug-wk2🛠 watch