REGRESSION(259626@main): Fullscreen and PiP buttons don't work in a media document #10215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jernoble
approved these changes
Feb 16, 2023
|
|
EWS run on current version of this PR (hash e249153)
|
…edia document https://bugs.webkit.org/show_bug.cgi?id=252417 rdar://105469592 Reviewed by Jer Noble. * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::enterFullscreen): Consume a transient activation if fullscreen is required, but don't reject is there is no activation because this method can not be called unless the element is allowed to enter fullscreen. Canonical link: https://commits.webkit.org/260401@main
webkit-early-warning-system
force-pushed
the
fix-fullscreen-transient-activation
branch
from
e249153 to
6db3bff
Compare
|
Committed 260401@main (6db3bff): https://commits.webkit.org/260401@main Reviewed commits have been landed. Closing PR #10215 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6db3bff
e249153
🧪 ios-wk2🧪 gtk-wk2🧪 api-ios🧪 api-gtk🧪 mac-wk2