Skip to content

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Feb 21, 2023

8722815

[WebCryptoAPI] Secure Curves have no namedCurve
https://bugs.webkit.org/show_bug.cgi?id=252555
rdar://problem/105666277

Reviewed by Chris Dumez.

As per https://wicg.github.io/webcrypto-secure-curves/#ed25519-description, the key algorithm is a simple KeyAlgorithm.
Update code accordingly.
Covered by test change cherry-picked from WPT upstream.

* LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/util/helpers.js:
(assert_goodCryptoKey):
* Source/WebCore/crypto/keys/CryptoKeyOKP.cpp:
(WebCore::CryptoKeyOKP::algorithm const):

Canonical link: https://commits.webkit.org/260599@main

da54f41

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl 🧪 ios-wk2 🧪 api-mac 🧪 gtk-wk2
🧪 api-ios ✅ 🧪 mac-wk1 🧪 api-gtk
✅ 🛠 tv 🧪 mac-wk2
✅ 🛠 tv-sim 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@youennf youennf requested a review from zdobersek as a code owner February 21, 2023 08:29
@youennf youennf self-assigned this Feb 21, 2023
@youennf youennf added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Feb 21, 2023
@youennf youennf added the merge-queue Applied to send a pull request to merge-queue label Feb 21, 2023
https://bugs.webkit.org/show_bug.cgi?id=252555
rdar://problem/105666277

Reviewed by Chris Dumez.

As per https://wicg.github.io/webcrypto-secure-curves/#ed25519-description, the key algorithm is a simple KeyAlgorithm.
Update code accordingly.
Covered by test change cherry-picked from WPT upstream.

* LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/util/helpers.js:
(assert_goodCryptoKey):
* Source/WebCore/crypto/keys/CryptoKeyOKP.cpp:
(WebCore::CryptoKeyOKP::algorithm const):

Canonical link: https://commits.webkit.org/260599@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/WebCryptoAPI-Secure-Curves-have-no-namedCurve branch from da54f41 to 8722815 Compare February 21, 2023 10:02
@webkit-commit-queue
Copy link
Collaborator

Committed 260599@main (8722815): https://commits.webkit.org/260599@main

Reviewed commits have been landed. Closing PR #10435 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 8722815 into WebKit:main Feb 21, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants