Skip to content

Conversation

rr-codes
Copy link
Contributor

@rr-codes rr-codes commented Feb 27, 2023

655c6f7

Fix Live Text layout for images with vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=253020
rdar://101314828

Reviewed by Wenson Hsieh.

* LayoutTests/fast/images/text-recognition/mac/layout-for-vertical-writing-mode-expected.txt: Added.
* LayoutTests/fast/images/text-recognition/mac/layout-for-vertical-writing-mode.html: Added.
* Source/WebCore/PAL/pal/spi/cocoa/VisionKitCoreSPI.h:
* Source/WebCore/dom/ImageOverlay.cpp:
(WebCore::ImageOverlay::updateWithTextRecognitionResult):
* Source/WebCore/platform/TextRecognitionResult.h:
(WebCore::TextRecognitionLineData::TextRecognitionLineData):
* Source/WebCore/testing/Internals.cpp:
(WebCore::makeDataForLine):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
* Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm:
(WebKit::makeTextRecognitionResult):
* Source/WebKit/Shared/TextRecognitionResult.serialization.in:

Canonical link: https://commits.webkit.org/260968@main

061acad

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
❌ 🛠 🧪 merge ✅ 🛠 watch-sim

@rr-codes rr-codes self-assigned this Feb 27, 2023
@rr-codes rr-codes added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Feb 27, 2023
@rr-codes rr-codes added the merge-queue Applied to send a pull request to merge-queue label Feb 28, 2023
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/101314828 branch 2 times, most recently from b1e7fb7 to c76ad50 Compare February 28, 2023 21:57
https://bugs.webkit.org/show_bug.cgi?id=253020
rdar://101314828

Reviewed by Wenson Hsieh.

* LayoutTests/fast/images/text-recognition/mac/layout-for-vertical-writing-mode-expected.txt: Added.
* LayoutTests/fast/images/text-recognition/mac/layout-for-vertical-writing-mode.html: Added.
* Source/WebCore/PAL/pal/spi/cocoa/VisionKitCoreSPI.h:
* Source/WebCore/dom/ImageOverlay.cpp:
(WebCore::ImageOverlay::updateWithTextRecognitionResult):
* Source/WebCore/platform/TextRecognitionResult.h:
(WebCore::TextRecognitionLineData::TextRecognitionLineData):
* Source/WebCore/testing/Internals.cpp:
(WebCore::makeDataForLine):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
* Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm:
(WebKit::makeTextRecognitionResult):
* Source/WebKit/Shared/TextRecognitionResult.serialization.in:

Canonical link: https://commits.webkit.org/260968@main
@webkit-commit-queue
Copy link
Collaborator

Committed 260968@main (655c6f7): https://commits.webkit.org/260968@main

Reviewed commits have been landed. Closing PR #10751 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 655c6f7 into WebKit:main Feb 28, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Platform Portability improvements and other general platform improvements not driven directly by site bugs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants