-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Move background fetch quota check to BackgroundFetchStoreManager #10930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
youennf:eng/Move-background-fetch-quota-check-to-BackgroundFetchStoreManager
Mar 2, 2023
Merged
Move background fetch quota check to BackgroundFetchStoreManager #10930
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
youennf:eng/Move-background-fetch-quota-check-to-BackgroundFetchStoreManager
Mar 2, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash 300bcd3)
|
300bcd3
to
dc76346
Compare
EWS run on current version of this PR (hash dc76346)
|
cdumez
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://bugs.webkit.org/show_bug.cgi?id=253234 rdar://problem/106135736 Reviewed by Chris Dumez. Move the quota check from WebCore/BackgroundFetchEngine to WebKit/BackgroundFetchStoreManager. We pass down downloadTotal and uploadTotal for that reason. Resolve the background fetch promise after the quota check and the store operation have been done. This should solve http/wpt/background-fetch/background-fetch-persistency.window.html flakiness. * Source/WebCore/workers/service/background-fetch/BackgroundFetch.cpp: (WebCore::BackgroundFetch::storeResponse): (WebCore::BackgroundFetch::doStore): * Source/WebCore/workers/service/background-fetch/BackgroundFetch.h: * Source/WebCore/workers/service/background-fetch/BackgroundFetchEngine.cpp: (WebCore::BackgroundFetchEngine::startBackgroundFetch): * Source/WebCore/workers/service/background-fetch/BackgroundFetchStore.h: * Source/WebCore/workers/service/server/SWServer.h: (WebCore::SWServer::createBackgroundFetchRecordLoader): (WebCore::SWServer::requestBackgroundFetchSpace): Deleted. * Source/WebCore/workers/service/server/SWServerDelegate.h: * Source/WebKit/NetworkProcess/NetworkSession.cpp: (WebKit::NetworkSession::requestBackgroundFetchSpace): Deleted. * Source/WebKit/NetworkProcess/NetworkSession.h: * Source/WebKit/NetworkProcess/storage/BackgroundFetchStoreImpl.cpp: (WebKit::BackgroundFetchStoreImpl::storeFetch): * Source/WebKit/NetworkProcess/storage/BackgroundFetchStoreImpl.h: * Source/WebKit/NetworkProcess/storage/BackgroundFetchStoreManager.cpp: (WebKit::BackgroundFetchStoreManager::BackgroundFetchStoreManager): (WebKit::BackgroundFetchStoreManager::storeFetch): (WebKit::BackgroundFetchStoreManager::storeFetchAfterQuotaCheck): * Source/WebKit/NetworkProcess/storage/BackgroundFetchStoreManager.h: * Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp: (WebKit::OriginStorageManager::StorageBucket::backgroundFetchManager): (WebKit::OriginStorageManager::backgroundFetchManager): Canonical link: https://commits.webkit.org/261095@main
dc76346
to
6ca935c
Compare
Committed 261095@main (6ca935c): https://commits.webkit.org/261095@main Reviewed commits have been landed. Closing PR #10930 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6ca935c
dc76346
🛠 mac🧪 api-mac