Skip to content

Conversation

salinas-miguel
Copy link
Contributor

@salinas-miguel salinas-miguel commented Mar 21, 2023

9a7153a

[macOS] TestWebKitAPI.WebKit.MediaBufferingPolicy  is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=253658
rdar://problem/106508946

Reviewed by Jer Noble.

macOS shouldn't purge media playback resources on page suspension.
This behavior was changed in 261354@main. This is just aligning the test
case

* Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm:
(TEST):

Canonical link: https://commits.webkit.org/262438@main

8c876d9

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@salinas-miguel salinas-miguel self-assigned this Mar 21, 2023
@salinas-miguel salinas-miguel added the WebKit API For issues and bugs in the Web Kit public embedding APIs label Mar 21, 2023
@rniwa rniwa requested review from jernoble and eric-carlson March 22, 2023 02:04
@ryanhaddad
Copy link
Contributor

@salinas-miguel would you mind force pushing this branch again so it gets EWS triggered? It would be nice to get this landed soon to get the failing test off the dashboard.

@salinas-miguel salinas-miguel force-pushed the 253658-mac-suspended-media-playback branch from 8ee90ce to 8c876d9 Compare March 30, 2023 23:07
@salinas-miguel salinas-miguel added the merge-queue Applied to send a pull request to merge-queue label Mar 31, 2023
https://bugs.webkit.org/show_bug.cgi?id=253658
rdar://problem/106508946

Reviewed by Jer Noble.

macOS shouldn't purge media playback resources on page suspension.
This behavior was changed in 261354@main. This is just aligning the test
case

* Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm:
(TEST):

Canonical link: https://commits.webkit.org/262438@main
@webkit-commit-queue webkit-commit-queue force-pushed the 253658-mac-suspended-media-playback branch from 8c876d9 to 9a7153a Compare March 31, 2023 20:57
@webkit-commit-queue
Copy link
Collaborator

Committed 262438@main (9a7153a): https://commits.webkit.org/262438@main

Reviewed commits have been landed. Closing PR #11769 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 31, 2023
@webkit-commit-queue webkit-commit-queue merged commit 9a7153a into WebKit:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKit API For issues and bugs in the Web Kit public embedding APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants