Skip to content

[web-animations] make AnimationEffect and derived classes iso-allocated #12291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2023
Merged

[web-animations] make AnimationEffect and derived classes iso-allocated #12291

merged 1 commit into from
Apr 2, 2023

Conversation

graouts
Copy link
Contributor

@graouts graouts commented Apr 2, 2023 •
edited by webkit-early-warning-system
Loading

9486a59

[web-animations] make AnimationEffect and derived classes iso-allocated
https://bugs.webkit.org/show_bug.cgi?id=254883
rdar://107446275

Reviewed by Dean Jackson.

* Source/WebCore/animation/AnimationEffect.cpp:
* Source/WebCore/animation/AnimationEffect.h:
* Source/WebCore/animation/CustomEffect.cpp:
* Source/WebCore/animation/CustomEffect.h:
* Source/WebCore/animation/KeyframeEffect.cpp:
* Source/WebCore/animation/KeyframeEffect.h:

Canonical link: https://commits.webkit.org/262494@main

8a411b8

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@graouts graouts self-assigned this Apr 2, 2023
@graouts graouts added the Animations Bugs related to CSS + SVG animations and transitions label Apr 2, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Apr 2, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 8dee667)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 api-ios   🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🛠 tv   🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@graouts graouts requested review from grorg and anttijk April 2, 2023 10:34
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 2, 2023
@graouts graouts force-pushed the iso-allocated-animation-effect branch from 8dee667 to 8a411b8 Compare April 2, 2023 11:32
@graouts graouts removed the merging-blocked Applied to prevent a change from being merged label Apr 2, 2023
@graouts graouts changed the title [web-animations] make AnimationEffect and KeyframeEffect iso-allocated [web-animations] make AnimationEffect and derived classes iso-allocated Apr 2, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Apr 2, 2023 •
edited
Loading

EWS run on current version of this PR (hash 8a411b8)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@graouts graouts added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 2, 2023
@graouts
[web-animations] make AnimationEffect and derived classes iso-allocated
9486a59 
https://bugs.webkit.org/show_bug.cgi?id=254883
rdar://107446275

Reviewed by Dean Jackson.

* Source/WebCore/animation/AnimationEffect.cpp:
* Source/WebCore/animation/AnimationEffect.h:
* Source/WebCore/animation/CustomEffect.cpp:
* Source/WebCore/animation/CustomEffect.h:
* Source/WebCore/animation/KeyframeEffect.cpp:
* Source/WebCore/animation/KeyframeEffect.h:

Canonical link: https://commits.webkit.org/262494@main
@webkit-commit-queue webkit-commit-queue force-pushed the iso-allocated-animation-effect branch from 8a411b8 to 9486a59 Compare April 2, 2023 20:50
@webkit-commit-queue
Copy link
Collaborator

Committed 262494@main (9486a59): https://commits.webkit.org/262494@main

Reviewed commits have been landed. Closing PR #12291 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 9486a59 into WebKit:main Apr 2, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 2, 2023
@graouts graouts deleted the iso-allocated-animation-effect branch April 2, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grorg grorg grorg approved these changes

@anttijk anttijk Awaiting requested review from anttijk

Assignees

@graouts graouts

Labels
Animations Bugs related to CSS + SVG animations and transitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@graouts @webkit-early-warning-system @webkit-commit-queue @grorg @webkit-ews-buildbot