Skip to content

Add check for pixel buffer format in RemoteRenderingBackend::getPixelBufferForImageBuffer #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 0 commits into from
Jun 3, 2022
Merged

Add check for pixel buffer format in RemoteRenderingBackend::getPixelBufferForImageBuffer #1260

merged 0 commits into from
Jun 3, 2022

Conversation

nmoucht
Copy link
Contributor

@nmoucht nmoucht commented Jun 3, 2022 •
edited by webkit-early-warning-system
Loading

832ce11

Add check for pixel buffer format in RemoteRenderingBackend::getPixelBufferForImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=241243
<rdar://89611041 >

Reviewed by Simon Fraser.

Add check to ensure that pixel buffer format is supported.

* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::getPixelBufferForImageBuffer):

Canonical link: https://commits.webkit.org/251254@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@nmoucht nmoucht self-assigned this Jun 3, 2022
@nmoucht nmoucht added New Bugs Unclassified bugs are placed in this component until the correct component can be determined. WebKit Nightly Build labels Jun 3, 2022
@nmoucht nmoucht requested a review from smfr June 3, 2022 00:31
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label Jun 3, 2022
@nmoucht nmoucht removed merging-blocked Applied to prevent a change from being merged New Bugs Unclassified bugs are placed in this component until the correct component can be determined. WebKit Nightly Build labels Jun 3, 2022
@nmoucht nmoucht force-pushed the eng/Add-check-for-pixel-buffer-format-in-RemoteRenderingBackendgetPixelBufferForImageBuffer branch from b4f15ec to de68660 Compare June 3, 2022 00:42
@nmoucht nmoucht added New Bugs Unclassified bugs are placed in this component until the correct component can be determined. WebKit Nightly Build labels Jun 3, 2022
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label Jun 3, 2022
@nmoucht nmoucht added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jun 3, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Add-check-for-pixel-buffer-format-in-RemoteRenderingBackendgetPixelBufferForImageBuffer branch from de68660 to 832ce11 Compare June 3, 2022 05:36
@webkit-early-warning-system webkit-early-warning-system merged commit 832ce11 into WebKit:main Jun 3, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r295170 (251254@main): https://commits.webkit.org/251254@main

Reviewed commits have been landed. Closing PR #1260 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label Jun 3, 2022
@nmoucht nmoucht deleted the eng/Add-check-for-pixel-buffer-format-in-RemoteRenderingBackendgetPixelBufferForImageBuffer branch June 3, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smfr smfr smfr approved these changes

Assignees

@nmoucht nmoucht

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmoucht @webkit-early-warning-system @smfr