Fix over-release in ClientConnection::hostAppCodeSigningIdentifier

[LumingYin]

e57c456

Fix over-release in ClientConnection::hostAppCodeSigningIdentifier
https://bugs.webkit.org/show_bug.cgi?id=255384
rdar://107974725

Reviewed by Simon Fraser.

In rdar://107931346, we introduced a change that wraps the value returned by CFArrayGetValueAtIndex()
using adoptCF. However, since CFArrayGetValueAtIndex() doesn’t return a retained object, our code will
cause an over-release. To resolve this issue, do not wrap the value returned by CFArrayGetValueAtIndex()
using adoptCF.

Additionally, the keys and values array were incorrectly swapped, causing the returned bundleIdentifier
to be loginwindow instead of the belonging app. Fix this by swapping keys and values so they are in the
correct order.

* Source/WebKit/webpushd/PushClientConnection.mm:
(WebPushD::ClientConnection::bundleIdentifierFromAuditToken):
Swap keys and values so they are in the correct order, and do not wrap the value returned by
CFArrayGetValueAtIndex().

Canonical link: https://commits.webkit.org/262922@main

72981a3

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 3ea07be)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	🧪 api-mac	✅ 🛠 gtk
	⏳ 🧪 ios-wk2-wpt	🧪 mac-wk1	🧪 gtk-wk2
	✅ 🧪 api-ios	🧪 mac-wk2	🧪 api-gtk
	✅ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on current version of this PR (hash 72981a3)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-commit-queue]

Committed 262922@main (e57c456): https://commits.webkit.org/262922@main

Reviewed commits have been landed. Closing PR #12686 and removing active labels.