Skip to content

[EWS] Enable WPE and WinCairo queues for PRs #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 0 commits into from
Feb 11, 2022
Merged

[EWS] Enable WPE and WinCairo queues for PRs #138

merged 0 commits into from
Feb 11, 2022

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Feb 11, 2022 •
edited
Loading

ff4cbed

[EWS] Enable WPE and WinCairo queues for PRs
https://bugs.webkit.org/show_bug.cgi?id=236517
<rdar://problem/88823117 >

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/config.json:


Canonical link: https://commits.webkit.org/247143@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@JonWBedard JonWBedard self-assigned this Feb 11, 2022
@JonWBedard JonWBedard requested a review from aj062 February 11, 2022 18:27
aj062
aj062 approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@aj062 aj062 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ after removing gtk queue

Tools/CISupport/ews-build/config.json Outdated
@@ -349,9 +349,9 @@
{
"type": "AnyBranchScheduler", "name": "pullrequest",
"builderNames": [
"Bindings-Tests-EWS", "iOS-15-Build-EWS",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTK builder queue triggers layout-test and api tests queues as well. Those queues doesn't seem ready yet.

@JonWBedard JonWBedard force-pushed the eng/github-ews-enable-gtk-wpe branch from ac7007c to f8f4b89 Compare February 11, 2022 19:00
@JonWBedard JonWBedard changed the title [EWS] Enable GTK, WPE and WinCairo queues for PRs [EWS] Enable WPE and WinCairo queues for PRs Feb 11, 2022
@JonWBedard JonWBedard closed this Feb 11, 2022
@JonWBedard JonWBedard force-pushed the eng/github-ews-enable-gtk-wpe branch from f8f4b89 to ff4cbed Compare February 11, 2022 19:11
@JonWBedard JonWBedard merged commit ff4cbed into WebKit:main Feb 11, 2022
@JonWBedard
Copy link
Member Author

Landed https://commits.webkit.org/247143@main (ff4cbed)!

@JonWBedard JonWBedard deleted the eng/github-ews-enable-gtk-wpe branch February 11, 2022 19:11
@JonWBedard JonWBedard added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Nightly Build labels Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj062 aj062 aj062 approved these changes

Assignees

@JonWBedard JonWBedard

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonWBedard @aj062