[UI-side compositing] Significantly more scrolling sync events #14050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smfr
added
the
WebKit Process Model
|
EWS run on previous version of this PR (hash 031170f)
|
mattwoodrow
approved these changes
May 19, 2023
| @@ -123,6 +123,11 @@ | |||
| void RemoteScrollingTreeMac::didCommitTree() | |||
| { | |||
| ASSERT(isMainRunLoop()); | |||
| ASSERT(m_treeLock.isLocked()); | |||
There was a problem hiding this comment.
This could probably be WTF_REQUIRES_LOCK(m_treeLock) in the header for a compile-time guarantee instead of runtime.
smfr
force-pushed
the
eng/UI-side-compositing-Significantly-more-scrolling-sync-events
branch
from
031170f to
7b498cc
Compare
|
EWS run on current version of this PR (hash 7b498cc)
|
https://bugs.webkit.org/show_bug.cgi?id=257001 rdar://109535555 Reviewed by Matt Woodrow. In the web process scrolling model, we avoid doing some work when ThreadedScrollingTree::scrollingThreadIsActive() returns false, which means there are no scrolling animations running, and we haven't received a wheel event in the last 50ms. We need to replicate this for UI-process scrolling to optimize power. First, move scrollingThreadIsActive() to be ScrollingTree::hasRecentActivity(). Second, avoid sending `didRefreshDisplay()` to the scrolling thread if there's not recent activity. Third, return early from `RemoteLayerTreeEventDispatcher::mainThreadDisplayDidRefresh()` if there's no recent activity, avoiding a scrolling thread dispatch. Finally, return early from `RemoteScrollingTreeMac::didCommitTree()` if there are no scroll animations to start, avoiding another scrolling thread dispatch. * Source/WebCore/page/scrolling/ScrollingTree.cpp: (WebCore::ScrollingTree::hasRecentActivity): * Source/WebCore/page/scrolling/ScrollingTree.h: * Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp: (WebCore::ThreadedScrollingTree::willStartRenderingUpdate): (WebCore::ThreadedScrollingTree::displayDidRefresh): (WebCore::ThreadedScrollingTree::scrollingThreadIsActive): Deleted. * Source/WebCore/page/scrolling/ThreadedScrollingTree.h: * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.cpp: (WebKit::RemoteLayerTreeEventDispatcher::scrollingTreeWasRecentlyActive): (WebKit::RemoteLayerTreeEventDispatcher::mainThreadDisplayDidRefresh): * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.h: * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.mm: (WebKit::RemoteScrollingTreeMac::didCommitTree): Canonical link: https://commits.webkit.org/264230@main
webkit-commit-queue
force-pushed
the
eng/UI-side-compositing-Significantly-more-scrolling-sync-events
branch
from
7b498cc to
c6eb7d8
Compare
|
Committed 264230@main (c6eb7d8): https://commits.webkit.org/264230@main Reviewed commits have been landed. Closing PR #14050 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
webkit-commit-queue
pushed a commit
to smfr/WebKit
that referenced
this pull request
May 23, 2023
https://bugs.webkit.org/show_bug.cgi?id=257167 rdar://109685883 Unreviewed fix. Respond to review comment on WebKit#14050, using a WTF_REQUIRES_LOCK() annotation. * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.h: * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.mm: (WebKit::RemoteScrollingTreeMac::didCommitTree): Canonical link: https://commits.webkit.org/264405@main
mnutt
pushed a commit
to movableink/webkit
that referenced
this pull request
Jun 28, 2023
https://bugs.webkit.org/show_bug.cgi?id=257167 rdar://109685883 Unreviewed fix. Respond to review comment on WebKit/WebKit#14050, using a WTF_REQUIRES_LOCK() annotation. * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.h: * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.mm: (WebKit::RemoteScrollingTreeMac::didCommitTree): Canonical link: https://commits.webkit.org/264405@main
smfr
deleted the
eng/UI-side-compositing-Significantly-more-scrolling-sync-events
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c6eb7d8
7b498cc
🛠 wincairo🧪 wpe-wk2🧪 api-mac🧪 ios-wk2-wpt🧪 gtk-wk2🧪 api-ios🧪 mac-AS-debug-wk2🛠 tv-sim