Skip to content

[CMake] Export compile commands for GTK development builds when using presets #14847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2023
Merged

[CMake] Export compile commands for GTK development builds when using presets #14847

merged 1 commit into from
Jun 13, 2023

Conversation

obyknovenius
Copy link
Contributor

@obyknovenius obyknovenius commented Jun 10, 2023 •
edited by webkit-early-warning-system
Loading

068c27d

[CMake] Export compile commands for GTK development builds when using presets
https://bugs.webkit.org/show_bug.cgi?id=257936

Reviewed by Philippe Normand.

Currently, `compile_commands.json` is generated when using `build-webkit`
script but not when using `CMakePresets`.

* CMakePresets.json:

Canonical link: https://commits.webkit.org/265113@main

e46f80b

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@obyknovenius obyknovenius self-assigned this Jun 10, 2023
@obyknovenius obyknovenius added the CMake Bugzilla component for CMake build system changes label Jun 10, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 10, 2023 •
edited
Loading

EWS run on current version of this PR (hash e46f80b)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 10, 2023
@obyknovenius obyknovenius added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jun 13, 2023
@obyknovenius
[CMake] Export compile commands for GTK development builds when using…
068c27d 
… presets

https://bugs.webkit.org/show_bug.cgi?id=257936

Reviewed by Philippe Normand.

Currently, `compile_commands.json` is generated when using `build-webkit`
script but not when using `CMakePresets`.

* CMakePresets.json:

Canonical link: https://commits.webkit.org/265113@main
@webkit-commit-queue webkit-commit-queue force-pushed the cmake/presets/export-compile-commands branch from e46f80b to 068c27d Compare June 13, 2023 11:04
@webkit-commit-queue
Copy link
Collaborator

Committed 265113@main (068c27d): https://commits.webkit.org/265113@main

Reviewed commits have been landed. Closing PR #14847 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 068c27d into WebKit:main Jun 13, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 13, 2023
@obyknovenius obyknovenius deleted the cmake/presets/export-compile-commands branch June 13, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philn philn philn approved these changes

Assignees

@obyknovenius obyknovenius

Labels

CMake Bugzilla component for CMake build system changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@obyknovenius @webkit-early-warning-system @webkit-commit-queue @philn @webkit-ews-buildbot