Skip to content

[gtest][CMake] Compile the unified source gtest-all.cc #15723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2023
Merged

[gtest][CMake] Compile the unified source gtest-all.cc #15723

merged 1 commit into from
Jul 13, 2023
+1 −8

Conversation

fujii
Copy link
Contributor

@fujii fujii commented Jul 11, 2023 •
edited by webkit-early-warning-system
Loading

805f2b5

[gtest][CMake] Compile the unified source gtest-all.cc
https://bugs.webkit.org/show_bug.cgi?id=259090

Reviewed by Yusuke Suzuki.

clang-cl reported the following warning for Windows port:
> ThirdParty\gtest\src\gtest-filepath.cc(68,12): warning: unused variable 'kAlternatePathSeparatorString' [-Wunused-const-variable]

clang-cl doesn't report this warning for the upstream google-test
because it's using gtest-all.cc. Let's use it in WebKit.

* Source/ThirdParty/gtest/CMakeLists.txt:

Canonical link: https://commits.webkit.org/266025@main

b818a46

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@fujii fujii self-assigned this Jul 11, 2023
@fujii fujii added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jul 11, 2023
@fujii fujii requested a review from rkirsling July 11, 2023 01:51
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 11, 2023 •
edited
Loading

EWS run on current version of this PR (hash b818a46)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@fujii fujii requested review from donny-dont and mcatanzaro July 11, 2023 03:46
Constellation
Constellation approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@fujii fujii added the merge-queue Applied to send a pull request to merge-queue label Jul 13, 2023
@fujii
[gtest][CMake] Compile the unified source gtest-all.cc
805f2b5 
https://bugs.webkit.org/show_bug.cgi?id=259090

Reviewed by Yusuke Suzuki.

clang-cl reported the following warning for Windows port:
> ThirdParty\gtest\src\gtest-filepath.cc(68,12): warning: unused variable 'kAlternatePathSeparatorString' [-Wunused-const-variable]

clang-cl doesn't report this warning for the upstream google-test
because it's using gtest-all.cc. Let's use it in WebKit.

* Source/ThirdParty/gtest/CMakeLists.txt:

Canonical link: https://commits.webkit.org/266025@main
@webkit-commit-queue
Copy link
Collaborator

Committed 266025@main (805f2b5): https://commits.webkit.org/266025@main

Reviewed commits have been landed. Closing PR #15723 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 805f2b5 into WebKit:main Jul 13, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 13, 2023
@fujii fujii deleted the eng/gtest-all branch July 14, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Constellation Constellation Constellation approved these changes

@rkirsling rkirsling Awaiting requested review from rkirsling

@donny-dont donny-dont Awaiting requested review from donny-dont

@mcatanzaro mcatanzaro Awaiting requested review from mcatanzaro

Assignees

@fujii fujii

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fujii @webkit-early-warning-system @webkit-commit-queue @Constellation