Skip to content

Add fantasai to contributors.json #15855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2023
Merged

Add fantasai to contributors.json #15855

merged 1 commit into from
Jul 15, 2023

Conversation

fantasai
Copy link
Contributor

@fantasai fantasai commented Jul 15, 2023 •
edited by webkit-early-warning-system
Loading

@fantasai fantasai requested a review from JonWBedard as a code owner July 15, 2023 00:13
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 15, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 057c85a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc ✅ 🧪 api-ios   🧪 mac-wk2 ✅ 🧪 api-gtk
⏳ 🛠 🧪 jsc-arm64 ⏳ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2
⏳ 🛠 tv-sim
⏳ 🛠 watch
⏳ 🛠 watch-sim

aproskuryakov
aproskuryakov reviewed Jul 15, 2023
View reviewed changes
metadata/contributors.json Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this needs to come first, so that Bugzilla autofill uses it (or we could change your Bugzilla email address instead).

@litherum litherum self-requested a review July 15, 2023 00:20
@fantasai fantasai force-pushed the eng/Add-fantasai-to-contributors-json branch from 057c85a to 2aae4b4 Compare July 15, 2023 00:25
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 15, 2023 •
edited
Loading

EWS run on current version of this PR (hash 2aae4b4)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
  🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
  🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge   🛠 watch-sim

@litherum litherum added the merge-queue Applied to send a pull request to merge-queue label Jul 15, 2023
@nt1m nt1m added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 15, 2023
@fantasai @nt1m
Add fantasai to contributors.json
bbbec87 
https://bugs.webkit.org/show_bug.cgi?id=259234
rdar://112296224

Reviewed by Myles C. Maxfield and Alexey Proskuryakov.

Adding myself per Myles's instructions.

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/266077@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Add-fantasai-to-contributors-json branch from 2aae4b4 to bbbec87 Compare July 15, 2023 01:50
@webkit-commit-queue
Copy link
Collaborator

Committed 266077@main (bbbec87): https://commits.webkit.org/266077@main

Reviewed commits have been landed. Closing PR #15855 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit bbbec87 into WebKit:main Jul 15, 2023
@webkit-commit-queue webkit-commit-queue removed merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litherum litherum litherum approved these changes

@aproskuryakov aproskuryakov aproskuryakov approved these changes

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

Assignees

@fantasai fantasai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fantasai @webkit-early-warning-system @webkit-commit-queue @litherum @aproskuryakov @nt1m