Skip to content

Fix content-visibility-050.html flakiness #16343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2023
Merged

Fix content-visibility-050.html flakiness #16343

merged 1 commit into from
Aug 3, 2023

Conversation

rwlbuis
Copy link
Contributor

@rwlbuis rwlbuis commented Aug 3, 2023 •
edited by webkit-early-warning-system
Loading

1424a23

Fix content-visibility-050.html flakiness
https://bugs.webkit.org/show_bug.cgi?id=238033

Reviewed by Tim Nguyen.

Import test from WPT.

* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-050.html:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/266542@main

933c9d8

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@rwlbuis rwlbuis self-assigned this Aug 3, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 3, 2023 •
edited
Loading

EWS run on current version of this PR (hash 933c9d8)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@rwlbuis rwlbuis added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Aug 3, 2023
nt1m
nt1m approved these changes Aug 3, 2023
View reviewed changes
...ported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-050.html
t.step(() => assert_greater_than(document.scrollingElement.scrollTop, 500));
t.done();
});
step_timeout(finish, 0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible followup: We should wait for a scroll event here, something like: https://github.com/web-platform-tests/wpt/blob/611e18d18cc233b5e033a2034cb8b117b02dd685/css/css-scroll-snap/scroll-target-margin-005.html#L27-L30

@rwlbuis rwlbuis added the merge-queue Applied to send a pull request to merge-queue label Aug 3, 2023
@rwlbuis
Fix content-visibility-050.html flakiness
1424a23 
https://bugs.webkit.org/show_bug.cgi?id=238033

Reviewed by Tim Nguyen.

Import test from WPT.

* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-050.html:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/266542@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/REGRESSION248014main--macOS-WK2--importedw3cweb-platform-testscsscss-containcontent-visibilitycontent-visibility-050-html-is-a-flaky-TEXT-failure branch from 933c9d8 to 1424a23 Compare August 3, 2023 17:24
@webkit-commit-queue
Copy link
Collaborator

Committed 266542@main (1424a23): https://commits.webkit.org/266542@main

Reviewed commits have been landed. Closing PR #16343 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 1424a23 into WebKit:main Aug 3, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 3, 2023
@rwlbuis rwlbuis deleted the eng/REGRESSION248014main--macOS-WK2--importedw3cweb-platform-testscsscss-containcontent-visibilitycontent-visibility-050-html-is-a-flaky-TEXT-failure branch August 22, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nt1m nt1m nt1m approved these changes

Assignees

@rwlbuis rwlbuis

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rwlbuis @webkit-early-warning-system @webkit-commit-queue @nt1m