Skip to content

[GTK][WPE] Enable libbacktrace support #18807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2023
Merged

[GTK][WPE] Enable libbacktrace support #18807

merged 1 commit into from
Oct 7, 2023

Conversation

philn
Copy link
Member

@philn philn commented Oct 7, 2023 •
edited by webkit-early-warning-system
Loading

343ea78

[GTK][WPE] Enable libbacktrace support
https://bugs.webkit.org/show_bug.cgi?id=262837

Reviewed by Michael Catanzaro.

* Source/cmake/OptionsGTK.cmake: Enable libbacktrace and make indentation consistent (4 spaces).
* Source/cmake/OptionsWPE.cmake: Ditto.

Canonical link: https://commits.webkit.org/269037@main

5f1bc94

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@philn philn requested a review from a team as a code owner October 7, 2023 09:26
@philn philn self-assigned this Oct 7, 2023
@philn philn added the WebKitGTK Bugs related to the Gtk API layer. label Oct 7, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 7, 2023 •
edited
Loading

EWS run on current version of this PR (hash 5f1bc94)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@philn philn added the merge-queue Applied to send a pull request to merge-queue label Oct 7, 2023
@philn
[GTK][WPE] Enable libbacktrace support
343ea78 
https://bugs.webkit.org/show_bug.cgi?id=262837

Reviewed by Michael Catanzaro.

* Source/cmake/OptionsGTK.cmake: Enable libbacktrace and make indentation consistent (4 spaces).
* Source/cmake/OptionsWPE.cmake: Ditto.

Canonical link: https://commits.webkit.org/269037@main
@webkit-commit-queue
Copy link
Collaborator

Committed 269037@main (343ea78): https://commits.webkit.org/269037@main

Reviewed commits have been landed. Closing PR #18807 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 343ea78 into WebKit:main Oct 7, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 7, 2023
@philn philn deleted the eng/262837 branch October 7, 2023 14:06
@dpino dpino mentioned this pull request Oct 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcatanzaro mcatanzaro mcatanzaro approved these changes

Assignees

@philn philn

Labels
WebKitGTK Bugs related to the Gtk API layer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@philn @webkit-early-warning-system @webkit-commit-queue @mcatanzaro