Skip to content

[GLIB] Install libjxl dependency if exits on Debian/Ubuntu #19412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2023
Merged

[GLIB] Install libjxl dependency if exits on Debian/Ubuntu #19412

merged 1 commit into from
Oct 24, 2023

Conversation

obyknovenius
Copy link
Contributor

@obyknovenius obyknovenius commented Oct 23, 2023 •
edited by webkit-early-warning-system
Loading

55805b4

[GLIB] Install `libjxl` dependency if exits on Debian/Ubuntu
https://bugs.webkit.org/show_bug.cgi?id=263519

Reviewed by Adrian Perez de Castro.

Ubuntu packages `libjxl` since 23.10.
https://packages.ubuntu.com/search?keywords=jpeg-xl&;searchon=names&suite=all&section=all

* Tools/glib/dependencies/apt:

Canonical link: https://commits.webkit.org/269706@main

b9e073e

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ❌ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
❌ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
❌ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@obyknovenius obyknovenius requested a review from a team as a code owner October 23, 2023 11:00
@obyknovenius obyknovenius self-assigned this Oct 23, 2023
@obyknovenius obyknovenius added the WebKitGTK Bugs related to the Gtk API layer. label Oct 23, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 23, 2023 •
edited
Loading

EWS run on current version of this PR (hash b9e073e)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ❌ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
❌ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
❌ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 23, 2023
@mcatanzaro
Copy link
Contributor

What about Arch and Fedora? Please keep the three distros synced.

@obyknovenius obyknovenius added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Oct 24, 2023
@webkit-commit-queue webkit-commit-queue force-pushed the glib/depndencies/apt/libjxl-dev branch from b9e073e to 55805b4 Compare October 24, 2023 09:26
@webkit-commit-queue
Copy link
Collaborator

Committed 269706@main (55805b4): https://commits.webkit.org/269706@main

Reviewed commits have been landed. Closing PR #19412 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 55805b4 into WebKit:main Oct 24, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 24, 2023
@obyknovenius obyknovenius deleted the glib/depndencies/apt/libjxl-dev branch October 24, 2023 12:34
@obyknovenius
Copy link
Contributor Author

What about Arch and Fedora? Please keep the three distros synced.

libjxl-devel is already on the list of dnf dependencies:

WebKit/Tools/glib/dependencies/dnf

Line 27 in 55805b4

libjxl-devel

I can add it to the pacman dependencies too but I can't test it, since I don't have any machine with Arch.

@mcatanzaro
Copy link
Contributor

I can add it to the pacman dependencies too but I can't test it, since I don't have any machine with Arch.

You don't need to test it. Just make sure it's a valid package name using https://archlinux.org/packages/

@obyknovenius obyknovenius mentioned this pull request Oct 24, 2023
Merged
@obyknovenius
Copy link
Contributor Author

I can add it to the pacman dependencies too but I can't test it, since I don't have any machine with Arch.

You don't need to test it. Just make sure it's a valid package name using https://archlinux.org/packages/

I made a PR: #19412

webkit-commit-queue pushed a commit to obyknovenius/WebKit that referenced this pull request Oct 24, 2023
@obyknovenius
[GLIB] Install libjxl dependency on Arch
0fda055 
https://bugs.webkit.org/show_bug.cgi?id=263588

Reviewed by Michael Catanzaro.

Similarly to WebKit#19412,
we should install `libjxl` dependency on Arch.

* Tools/glib/dependencies/pacman:

Canonical link: https://commits.webkit.org/269733@main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aperezdc aperezdc aperezdc approved these changes

Assignees

@obyknovenius obyknovenius

Labels
WebKitGTK Bugs related to the Gtk API layer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@obyknovenius @webkit-early-warning-system @mcatanzaro @webkit-commit-queue @aperezdc @webkit-ews-buildbot