-
Notifications
You must be signed in to change notification settings - Fork 1.6k
GraphicsContextGL::m_layerComposited is a redundant flag #19633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
kkinnunen-apple:webgl-remmotve-layercomposited-for-review-1
Oct 30, 2023
Merged
GraphicsContextGL::m_layerComposited is a redundant flag #19633
webkit-commit-queue
merged 1 commit into
WebKit:main
from
kkinnunen-apple:webgl-remmotve-layercomposited-for-review-1
Oct 30, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EWS run on previous version of this PR (hash 93e33e0)
|
donny-dont
approved these changes
Oct 27, 2023
93e33e0
to
6c201cc
Compare
EWS run on current version of this PR (hash 6c201cc)
|
https://bugs.webkit.org/show_bug.cgi?id=263772 rdar://117582088 Reviewed by Don Olmstead. The flag would be queried by WebGLRenderingContextBase::clearIfComposited to understand if the backbuffer needs to be cleared after prepareForDisplay before next draw call. This is already taken care of by buffersToAutoClear variable which tracks this state and is reset in same location, at prepareForDisplay. The flag would be queried by GraphicsContextGL prepareForDisplay implementations. This is taken care of by the caller, e.g. the caller only schedules a prepare when draw has happened. Work towards simplifying the default framebuffer implementation, in order to implement premultipliedAlpha compositing. * Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::clearIfComposited): (WebCore::WebGLRenderingContextBase::prepareForDisplay): * Source/WebCore/platform/graphics/GraphicsContextGL.cpp: (WebCore::GraphicsContextGL::markContextChanged): (WebCore::GraphicsContextGL::markLayerComposited): (WebCore::GraphicsContextGL::layerComposited const): Deleted. * Source/WebCore/platform/graphics/GraphicsContextGL.h: * Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm: (WebCore::GraphicsContextGLCocoa::prepareForDisplayWithFinishedSignal): * Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp: (WebCore::GraphicsContextGLGBM::prepareForDisplay): * Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp: (WebCore::GraphicsContextGLTextureMapperANGLE::prepareForDisplay): * Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp: (WebKit::RemoteGraphicsContextGLProxy::markContextChanged): Canonical link: https://commits.webkit.org/269939@main
6c201cc
to
db15813
Compare
Committed 269939@main (db15813): https://commits.webkit.org/269939@main Reviewed commits have been landed. Closing PR #19633 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
db15813
6c201cc
🧪 wpe-wk2