Rewrite Python CGI under http/tests/xmlhttprequest to use binary mode for stdout for Windows Python #20023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujii
added
the
Tools / Tests
|
EWS run on current version of this PR (hash 1247821)
|
fujii
added
the
safe-merge-queue
webkit-ews-buildbot
added
merge-queue
|
Safe-Merge-Queue: Build #2525. |
… for stdout for Windows Python https://bugs.webkit.org/show_bug.cgi?id=264238 Reviewed by Ross Kirsling. Windows Python automatically converts '\n' to '\r\n' in text mode. Use sys.stdout.buffer.write instead of sys.stdout.write. * LayoutTests/http/tests/xmlhttprequest/resources/access-control-allow-lists.py: * LayoutTests/http/tests/xmlhttprequest/resources/access-control-allow-with-body.py: * LayoutTests/http/tests/xmlhttprequest/resources/basic-auth-default/dir1/basic-auth.py: * LayoutTests/http/tests/xmlhttprequest/resources/basic-auth-default/dir2/basic-auth.py: * LayoutTests/http/tests/xmlhttprequest/resources/basic-auth-default/dir2/catch.py: * LayoutTests/http/tests/xmlhttprequest/resources/chunked-transfer.py: * LayoutTests/http/tests/xmlhttprequest/resources/cross-origin-authorization.py: * LayoutTests/http/tests/xmlhttprequest/resources/cross-origin-check-cookies.py: * LayoutTests/http/tests/xmlhttprequest/resources/cross-origin-no-authorization.py: * LayoutTests/http/tests/xmlhttprequest/resources/cross-origin-preflight-get.py: * LayoutTests/http/tests/xmlhttprequest/resources/cross-origin-set-cookies.py: * LayoutTests/http/tests/xmlhttprequest/resources/logout/resource.py: * LayoutTests/http/tests/xmlhttprequest/resources/re-login/resource.py: * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/270258@main
webkit-commit-queue
force-pushed
the
eng/Rewrite-Python-CGI-under-http-tests-xmlhttprequest-for-Windows-Python
branch
from
1247821 to
824e7a8
Compare
|
Committed 270258@main (824e7a8): https://commits.webkit.org/270258@main Reviewed commits have been landed. Closing PR #20023 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
fujii
deleted the
eng/Rewrite-Python-CGI-under-http-tests-xmlhttprequest-for-Windows-Python
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
824e7a8
1247821
🧪 wpe-wk2