-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[JSC] Use synchronous GCActivityCallback GC with RunLoopObserver #21050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
Constellation:eng/JSC-Use-synchronous-GCActivityCallback-GC-with-RunLoopObserver
Nov 30, 2023
Merged
[JSC] Use synchronous GCActivityCallback GC with RunLoopObserver #21050
webkit-commit-queue
merged 1 commit into
WebKit:main
from
Constellation:eng/JSC-Use-synchronous-GCActivityCallback-GC-with-RunLoopObserver
Nov 30, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
EWS run on previous version of this PR (hash 49f77af) |
whsieh
approved these changes
Nov 29, 2023
49f77af
to
5e9f357
Compare
EWS run on current version of this PR (hash 5e9f357) |
https://bugs.webkit.org/show_bug.cgi?id=265515 rdar://118930139 Reviewed by Wenson Hsieh. Now we can schedule GC only when we are idle from GCActivityCallback. So we do not need to run async version. This patch changes two things. 1. We set up RunLoopObserver and run GC when RunLoop gets idle state after GCActivityCallback detects GC opportunities. 2. We use sync GC instead of async GC since we now run this only when we are idle. We do not need to run async version. * Source/JavaScriptCore/heap/EdenGCActivityCallback.cpp: (JSC::EdenGCActivityCallback::EdenGCActivityCallback): (JSC::EdenGCActivityCallback::doCollection): * Source/JavaScriptCore/heap/EdenGCActivityCallback.h: (JSC::EdenGCActivityCallback::tryCreate): * Source/JavaScriptCore/heap/FullGCActivityCallback.cpp: (JSC::FullGCActivityCallback::FullGCActivityCallback): (JSC::FullGCActivityCallback::doCollection): * Source/JavaScriptCore/heap/FullGCActivityCallback.h: (JSC::FullGCActivityCallback::tryCreate): * Source/JavaScriptCore/heap/GCActivityCallback.cpp: (JSC::GCActivityCallback::GCActivityCallback): * Source/JavaScriptCore/heap/GCActivityCallback.h: * Source/JavaScriptCore/heap/Synchronousness.h: * Source/WebCore/page/OpportunisticTaskScheduler.cpp: (WebCore::OpportunisticTaskScheduler::FullGCActivityCallback::FullGCActivityCallback): (WebCore::OpportunisticTaskScheduler::FullGCActivityCallback::doCollection): (WebCore::OpportunisticTaskScheduler::EdenGCActivityCallback::EdenGCActivityCallback): (WebCore::OpportunisticTaskScheduler::EdenGCActivityCallback::doCollection): * Source/WebCore/page/OpportunisticTaskScheduler.h: Canonical link: https://commits.webkit.org/271324@main
5e9f357
to
e0c479c
Compare
Committed 271324@main (e0c479c): https://commits.webkit.org/271324@main Reviewed commits have been landed. Closing PR #21050 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
JavaScriptCore
For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e0c479c
5e9f357