Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[git-webkit] Support —oneline in log command #219

Merged
merged 0 commits into from Mar 28, 2022
Merged

[git-webkit] Support —oneline in log command #219

merged 0 commits into from Mar 28, 2022

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Mar 22, 2022 •
edited

b1079a1

[git-webkit] Support —oneline in log command
https://bugs.webkit.org/show_bug.cgi?id=238209
<rdar://problem/90660142 >

Reviewed by Dewei Zhu.

* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:
(FilteredCommand): Header lines don't always start with 'commit'
(FilteredCommand.main): Handle --online output
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/log.py:
(Log):
(Log.parser): Add various `git log` options.
(Log.main): Forward `git log` options.


Canonical link: https://commits.webkit.org/248944@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@JonWBedard JonWBedard self-assigned this Mar 22, 2022
dewei-zhu
dewei-zhu approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@dewei-zhu dewei-zhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/log.py Outdated
)
parser.add_argument(
'--pretty', '--format', type=str,
help='''Pretty-print the contents of the commit logs in a given format, where <format> can be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe consider using

            help='Pretty-print the contents of the commit logs in a given format, where <format> can be'
                 'one of oneline, short, medium, full, fuller, reference, email, raw, format:<string> and'
                      ....

@JonWBedard JonWBedard closed this Mar 28, 2022
@JonWBedard JonWBedard force-pushed the eng/git-webkit-Support-oneline-in-log-command branch from c5d88ec to b1079a1 Compare March 28, 2022 20:43
@JonWBedard JonWBedard merged commit b1079a1 into WebKit:main Mar 28, 2022
@JonWBedard
Copy link
Member Author

Landed https://commits.webkit.org/248944@main (b1079a1)!

@JonWBedard JonWBedard deleted the eng/git-webkit-Support-oneline-in-log-command branch March 28, 2022 20:44
@JonWBedard JonWBedard added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Nightly Build labels Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dewei-zhu dewei-zhu dewei-zhu approved these changes

@sundiamonde sundiamonde Awaiting requested review from sundiamonde

Assignees

@JonWBedard JonWBedard

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
2 participants
@JonWBedard @dewei-zhu